Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: map: add switch button for smooth-travel on map #5812

Merged
merged 1 commit into from
Nov 23, 2023
Merged

front: map: add switch button for smooth-travel on map #5812

merged 1 commit into from
Nov 23, 2023

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Nov 22, 2023 •
edited
Loading

  • add smoothTravel selector and updateSmoothTravel dispatch function
  • add smoothTravel FormatSwitch in MapSettingsBackgroundSwitches.tsx
  • add smoothTravel in condition to enable flyTo() in MapSearch.tsx
  • add translations in map-settings.json (en/fr)

close #5813

@Yohh
front: map: add switch button for smooth-travel on map
2986e9a 
- add smoothTravel selector and updateSmoothTravel dispatch function
- add smoothTravel FormatSwitch in MapSettingsBackgroundSwitches.tsx
- add smoothTravel in condition to enable flyTo() in MapSearch.tsx
- add translations in map-settings.json (en/fr)
@Yohh Yohh requested a review from a team as a code owner November 22, 2023 20:34
@Yohh Yohh added area:front Work on Standard OSRD Interface modules module:carto OSRD mapviz standard module labels Nov 22, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (6958130) 19.61% compared to head (2986e9a) 19.61%.

Files Patch % Lines
...mon/Map/Settings/MapSettingsBackgroundSwitches.tsx 0.00% 17 Missing ⚠️
front/src/common/Map/Search/MapSearch.tsx 0.00% 2 Missing ⚠️
front/src/reducers/map/index.ts 66.66% 2 Missing ⚠️
front/src/reducers/map/selectors.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5812      +/-   ##
============================================
- Coverage     19.61%   19.61%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      907              
  Lines        107662   107685      +23     
  Branches       2623     2623              
============================================
+ Hits          21120    21124       +4     
- Misses        84986    85005      +19     
  Partials       1556     1556
Flag Coverage Δ
front 8.60% <15.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nicolaswurtz
nicolaswurtz approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Perfect. Incredible. Wonderful job. Marry me please !

@Yohh Yohh added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 2019297 Nov 23, 2023
7 checks passed
@Yohh Yohh deleted the yoh/front-add-switch-for-smooth-travel-on-map-search branch November 23, 2023 08:59
@flomonster flomonster mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules module:carto OSRD mapviz standard module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: map: need switch button for enable/disable smooth-travel on map
2 participants
@Yohh @nicolaswurtz