Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix space time chart resize #5848

Merged
merged 1 commit into from
Nov 29, 2023
Merged

front: fix space time chart resize #5848

merged 1 commit into from
Nov 29, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 24, 2023

closes #4326

  • fix resize
  • rename height props

@clarani clarani requested a review from a team as a code owner November 24, 2023 11:21
- fix resize
- rename height props
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (b6ead5b) 19.70% compared to head (b9ba137) 19.70%.

Files Patch % Lines
...esult/components/SpaceTimeChart/SpaceTimeChart.tsx 0.00% 37 Missing ⚠️
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 2 Missing ⚠️
.../src/applications/stdcm/views/OSRDStdcmResults.tsx 0.00% 2 Missing ⚠️
...ainschedule/components/ImportTrainSchedule/Map.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5848   +/-   ##
=========================================
  Coverage     19.70%   19.70%           
  Complexity     2345     2345           
=========================================
  Files           910      910           
  Lines        108075   108073    -2     
  Branches       2634     2634           
=========================================
  Hits          21299    21299           
+ Misses        85216    85214    -2     
  Partials       1560     1560           
Flag Coverage Δ
front 8.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@clarani clarani added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit 62e1536 Nov 29, 2023
7 checks passed
@clarani clarani deleted the cni-4326-resize-get branch November 29, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: Resize of GET is broken when resizing browser's window / harmonize resizing of GEV & other graphs
3 participants