Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: add missing signal fields to infra clones #5881

Merged
merged 1 commit into from
Nov 28, 2023
Merged

editoast: add missing signal fields to infra clones #5881

merged 1 commit into from
Nov 28, 2023

Conversation

shenriotpro
Copy link
Contributor

@shenriotpro shenriotpro commented Nov 27, 2023 •
edited
Loading

fixes #5828

@shenriotpro shenriotpro marked this pull request as ready for review November 27, 2023 17:03
@shenriotpro shenriotpro requested a review from a team as a code owner November 27, 2023 17:03
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f755dc9) 19.86% compared to head (e61b0b3) 19.86%.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5881      +/-   ##
============================================
- Coverage     19.86%   19.86%   -0.01%     
  Complexity     2122     2122              
============================================
  Files           910      910              
  Lines        108338   108338              
  Branches       2649     2649              
============================================
- Hits          21525    21524       -1     
- Misses        85259    85260       +1     
  Partials       1554     1554
Flag Coverage Δ
editoast 68.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flomonster
flomonster approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

axrolld
axrolld approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Should the tests be part of this PR as well ?

@shenriotpro
Copy link
Contributor Author

LGTM ! Should the tests be part of this PR as well ?

In theory yes, in practice I don't have a great solution for now..

Tguisnet
Tguisnet approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@shenriotpro shenriotpro added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit 4888355 Nov 28, 2023
9 of 10 checks passed
@shenriotpro shenriotpro deleted the shenriot-clone-infra branch November 28, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@Tguisnet Tguisnet Tguisnet approved these changes

@axrolld axrolld axrolld approved these changes

@Castavo Castavo Awaiting requested review from Castavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signals not displayed on a duplicated infra
4 participants
@shenriotpro @flomonster @Tguisnet @axrolld