Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix cities and PR overlap #5932

Merged
merged 1 commit into from
Dec 1, 2023
Merged

front: fix cities and PR overlap #5932

merged 1 commit into from
Dec 1, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Nov 30, 2023

fixes #3232

@anisometropie anisometropie requested a review from a team as a code owner November 30, 2023 14:00
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (459de94) 19.73% compared to head (dcd4ea8) 19.73%.

Files Patch % Lines
front/src/common/Map/Layers/OperationalPoints.tsx 0.00% 2 Missing ⚠️
front/src/common/Map/Layers/KPLabel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5932   +/-   ##
=========================================
  Coverage     19.73%   19.73%           
  Complexity     2117     2117           
=========================================
  Files           910      910           
  Lines        108673   108673           
  Branches       2663     2663           
=========================================
  Hits          21452    21452           
  Misses        85650    85650           
  Partials       1571     1571           
Flag Coverage Δ
front 8.43% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅
Thanks, this PR is great, the map is way clearer now !!

@anisometropie anisometropie added this pull request to the merge queue Dec 1, 2023
Merged via the queue into dev with commit 2e6ebb3 Dec 1, 2023
7 checks passed
@anisometropie anisometropie deleted the vcs/label-overlap branch December 1, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map: labels overlap
2 participants