Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor: move save button to action bar #5995

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

SharglutDev
Copy link
Contributor

close #5840

@SharglutDev SharglutDev force-pushed the pfn/front/editor-change-save-position branch 2 times, most recently from 8969f1c to 1580157 Compare December 5, 2023 13:29
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 235 lines in your changes are missing coverage. Please review.

Comparison is base (69d6902) 25.74% compared to head (c2dd221) 26.51%.
Report is 46 commits behind head on dev.

Files Patch % Lines
...cations/editor/tools/rangeEdition/tool-factory.tsx 0.00% 55 Missing ⚠️
...cations/editor/tools/pointEdition/tool-factory.tsx 0.00% 29 Missing ⚠️
...rc/applications/editor/tools/trackEdition/tool.tsx 0.00% 22 Missing ⚠️
...c/applications/editor/tools/switchEdition/tool.tsx 0.00% 21 Missing ⚠️
front/src/applications/editor/Editor.tsx 0.00% 19 Missing ⚠️
...lications/editor/tools/pointEdition/components.tsx 0.00% 19 Missing ⚠️
...ications/editor/tools/switchEdition/components.tsx 0.00% 16 Missing and 1 partial ⚠️
...c/applications/editor/tools/switchEdition/types.ts 0.00% 16 Missing ⚠️
...lications/editor/tools/trackEdition/components.tsx 0.00% 15 Missing and 1 partial ⚠️
...applications/editor/tools/selection/components.tsx 0.00% 9 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5995      +/-   ##
============================================
+ Coverage     25.74%   26.51%   +0.77%     
  Complexity     2117     2117              
============================================
  Files           926      930       +4     
  Lines        122479   122714     +235     
  Branches       2665     2669       +4     
============================================
+ Hits          31534    32542    +1008     
+ Misses        89372    88595     -777     
- Partials       1573     1577       +4     
Flag Coverage Δ
core 78.97% <ø> (-0.04%) ⬇️
editoast 74.55% <ø> (+0.70%) ⬆️
front 9.32% <0.00%> (+0.89%) ⬆️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/editor-change-save-position branch from 1580157 to 51113bf Compare December 5, 2023 15:55
@SharglutDev SharglutDev marked this pull request as ready for review December 5, 2023 18:26
@SharglutDev SharglutDev requested a review from a team as a code owner December 5, 2023 18:26
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested everything (creation of new objects and edition) ✅
Nice work !! 🎉

@SharglutDev SharglutDev force-pushed the pfn/front/editor-change-save-position branch from 51113bf to c2dd221 Compare December 6, 2023 10:51
@SharglutDev SharglutDev added this pull request to the merge queue Dec 6, 2023
Merged via the queue into dev with commit f3abe90 Dec 6, 2023
17 checks passed
@SharglutDev SharglutDev deleted the pfn/front/editor-change-save-position branch December 6, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the position of button to save and to delete in the objects edition form
2 participants