Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: fix conflicts being ignored during a stop #6094

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 11, 2023

Fix #6089

The problematic situation is reproduced in a unit test, that was an oversight.

Summary of the fix: when looking for conflicts for a given path segment, we now include an optional parameter describing the stop duration at the end of the segment

@eckter eckter requested a review from a team as a code owner December 11, 2023 10:37
@eckter eckter requested a review from multun December 11, 2023 10:37
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (381f900) 26.55% compared to head (d06c865) 26.56%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6094      +/-   ##
============================================
+ Coverage     26.55%   26.56%   +0.01%     
- Complexity     2118     2122       +4     
============================================
  Files           931      931              
  Lines        122945   122965      +20     
  Branches       2673     2675       +2     
============================================
+ Hits          32644    32663      +19     
- Misses        88716    88717       +1     
  Partials       1585     1585              
Flag Coverage Δ
core 78.98% <100.00%> (+0.03%) ⬆️
editoast 74.66% <ø> (-0.01%) ⬇️
front 9.33% <ø> (ø)
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Dec 11, 2023
Merged via the queue into dev with commit 8317520 Dec 11, 2023
17 checks passed
@eckter eckter deleted the ech/fix-stop-ignoring-conflict branch December 11, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stops are not handled in STDCM
2 participants