Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace editoast JsonValue by appropriate structs #6200

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Replace editoast JsonValue by appropriate structs #6200

merged 1 commit into from
Jan 8, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Dec 22, 2023

closes #5457

@hamz2a hamz2a requested a review from a team as a code owner December 22, 2023 08:57
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch from 9605c19 to 9bfe31f Compare December 22, 2023 09:03
@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c12f67) 26.90% compared to head (7c3258a) 27.47%.
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6200      +/-   ##
============================================
+ Coverage     26.90%   27.47%   +0.57%     
+ Complexity     2139     2136       -3     
============================================
  Files           932      954      +22     
  Lines        123970   125179    +1209     
  Branches       2689     2690       +1     
============================================
+ Hits          33352    34397    +1045     
- Misses        89013    89177     +164     
  Partials       1605     1605
Flag Coverage Δ
core 78.88% <ø> (+<0.01%) ⬆️
editoast 75.53% <100.00%> (+0.19%) ⬆️
front 9.47% <100.00%> (+<0.01%) ⬆️
gateway 2.54% <ø> (-0.02%) ⬇️
tests 84.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch from 9bfe31f to f42d2d7 Compare December 22, 2023 09:14
@flomonster flomonster changed the title editoast: replace serde_json::Value by appropriate structs Replace editoast JsonValue by appropriate structs Dec 22, 2023
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch 2 times, most recently from 33aaa84 to a6ed697 Compare December 22, 2023 11:00
flomonster
flomonster requested changes Dec 22, 2023
View reviewed changes
editoast/src/schema/errors.rs Outdated Show resolved Hide resolved
editoast/src/schema/errors.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/errors.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/objects.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/mod.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch from a6ed697 to 1c57563 Compare December 22, 2023 11:03
Tguisnet
Tguisnet requested changes Dec 22, 2023
View reviewed changes
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
editoast/src/schema/errors.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/objects.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
leovalais
leovalais requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. There are issues with the OpenApi annotations and generation, more info in the comments ⬇️

editoast/src/schema/rolling_stock/mod.rs Outdated Show resolved Hide resolved
editoast/openapi.yaml Outdated Show resolved Hide resolved
editoast/src/models/rolling_stock/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/mod.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch 4 times, most recently from 5042370 to f5b7d47 Compare December 26, 2023 17:26
leovalais
leovalais requested changes Dec 26, 2023
View reviewed changes
editoast/src/models/rolling_stock/light_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/models/rolling_stock/mod.rs Outdated Show resolved Hide resolved
editoast/src/schema/rolling_stock/light_rolling_stock.rs Show resolved Hide resolved
editoast/src/views/infra/errors.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch 4 times, most recently from d101589 to 861a01c Compare December 28, 2023 09:54
leovalais
leovalais requested changes Dec 28, 2023
View reviewed changes
editoast/src/models/rolling_stock/light_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/errors.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/objects.rs Show resolved Hide resolved
editoast/src/views/infra/routes.rs Show resolved Hide resolved
editoast/src/views/layers/mod.rs Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch 2 times, most recently from 0e758d6 to 741add3 Compare December 29, 2023 10:12
bougue-pe
bougue-pe approved these changes Jan 2, 2024
View reviewed changes
editoast/src/views/infra/auto_fixes.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/objects.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/objects.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-replace-serde-json-value-by-appropriate-structs branch from 741add3 to 7c3258a Compare January 3, 2024 09:04
@Wadjetz Wadjetz mentioned this pull request Jan 3, 2024
Merged
@hamz2a hamz2a enabled auto-merge January 3, 2024 16:43
flomonster
flomonster approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flomonster flomonster requested review from leovalais and removed request for leovalais January 8, 2024 09:46
leovalais
leovalais approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamz2a hamz2a added this pull request to the merge queue Jan 8, 2024
Merged via the queue into dev with commit 31ad979 Jan 8, 2024
18 checks passed
@hamz2a hamz2a deleted the hai/editoast-replace-serde-json-value-by-appropriate-structs branch January 8, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@leovalais leovalais leovalais approved these changes

@Tguisnet Tguisnet Tguisnet approved these changes

@bougue-pe bougue-pe bougue-pe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: replace serde_json::Value occurrences by actual structs where appropriate
5 participants
@hamz2a @flomonster @leovalais @Tguisnet @bougue-pe