Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: clean 🧹 #6237

Merged
merged 1 commit into from
Jan 11, 2024
Merged

front: clean 🧹 #6237

merged 1 commit into from
Jan 11, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 29, 2023

close #6236

@clarani clarani requested a review from a team as a code owner December 29, 2023 15:42
@codecov Codecov
Copy link

codecov bot commented Dec 29, 2023 •
edited
Loading

Codecov Report

Attention: 447 lines in your changes are missing coverage. Please review.

Comparison is base (bf6da3d) 27.66% compared to head (b5de461) 27.68%.

Files Patch % Lines
...scenario/components/ScenarioExplorer/MiniCards.tsx 0.00% 96 Missing and 1 partial ⚠️
front/src/common/Map/WarpedMap/DataLoader.tsx 0.00% 34 Missing ⚠️
...ponents/ScenarioExplorer/ScenarioExplorerModal.tsx 0.00% 18 Missing ⚠️
front/src/common/Map/Search/MapSearchSignal.tsx 0.00% 16 Missing and 1 partial ⚠️
front/src/common/Map/Layers/IGN_CADASTRE.tsx 0.00% 14 Missing ⚠️
...o/components/ScenarioExplorer/ScenarioExplorer.tsx 0.00% 14 Missing ⚠️
.../applications/operationalStudies/views/Project.tsx 0.00% 12 Missing ⚠️
...s/InfraSelector/InfraSelectorModalBodyStandard.tsx 0.00% 10 Missing and 1 partial ⚠️
...les/scenario/components/AddOrEditScenarioModal.tsx 0.00% 10 Missing and 1 partial ⚠️
front/src/applications/editor/Editor.tsx 0.00% 8 Missing ⚠️
... and 81 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6237      +/-   ##
============================================
+ Coverage     27.66%   27.68%   +0.02%     
  Complexity     2136     2136              
============================================
  Files           990      990              
  Lines        125902   125793     -109     
  Branches       2575     2574       -1     
============================================
  Hits          34832    34832              
+ Misses        89580    89472     -108     
+ Partials       1490     1489       -1
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.58% <ø> (-0.01%) ⬇️
front 8.71% <1.75%> (+0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SharglutDev
SharglutDev reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice refacto ! Left a few comments.

Found also two more components for your : null refacto :

  • CatenaryEditionLayers (line 180)
  • Project2Image

front/src/common/Loader/Loader.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Settings/MapSettings.tsx Outdated Show resolved Hide resolved
front/src/modules/rollingStock/components/RollingStockEditor/RollingStockEditorButtons.tsx Outdated Show resolved Hide resolved
front/src/modules/scenario/components/AddOrEditScenarioModal.tsx Outdated Show resolved Hide resolved
front/src/modules/scenario/components/ScenarioExplorer/ScenarioExplorer.tsx Outdated Show resolved Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceSettings.tsx Outdated Show resolved Hide resolved
@clarani clarani force-pushed the cni-6236-clean-architecture branch from b2b7584 to 556560d Compare January 4, 2024 13:25
anisometropie
anisometropie requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! the codebase needed some love.

front/src/applications/editor/components/EntityError.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/views/Scenario.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/views/Study.tsx Outdated Show resolved Hide resolved
front/src/common/Loaders/Loader.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Layers/BufferStops.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Layers/OSM.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Layers/LineSearchLayer.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Layers/IGN_SCAN25.tsx Outdated Show resolved Hide resolved
front/src/common/Map/Layers/IGN_CADASTRE.tsx Outdated Show resolved Hide resolved
front/src/applications/editor/tools/selection/components.tsx Outdated Show resolved Hide resolved
@clarani clarani force-pushed the cni-6236-clean-architecture branch from e13366f to 13e84d9 Compare January 5, 2024 09:57
@clarani
front: clean up code
b5de461 
- move ScenarioExplorer to module/scenario/components
- move InfraSelector to module/infra/components
- move some Grid, Loader and Notification in their own folder
- remove some useless renders (null)
- remove requests file
@clarani clarani added this pull request to the merge queue Jan 11, 2024
Merged via the queue into dev with commit 5647245 Jan 11, 2024
20 checks passed
@clarani clarani deleted the cni-6236-clean-architecture branch January 11, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wadjetz Wadjetz Wadjetz approved these changes

@anisometropie anisometropie anisometropie approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: move some components to their module repository
4 participants
@clarani @Wadjetz @anisometropie @SharglutDev