Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

railjson: split up TVM into TVM300 and TVM430 signaling systems #6328

Merged
merged 2 commits into from
Jan 12, 2024
Merged

railjson: split up TVM into TVM300 and TVM430 signaling systems #6328

merged 2 commits into from
Jan 12, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Jan 11, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (bf6da3d) 27.66% compared to head (b2e1915) 27.70%.
Report is 6 commits behind head on dev.

Files Patch % Lines
...ain/kotlin/fr/sncf/osrd/signaling/tvm430/TVM430.kt 61.53% 5 Missing ⚠️
...in/fr/sncf/osrd/signaling/tvm300/TVM300toTVM300.kt 42.85% 4 Missing ⚠️
...in/fr/sncf/osrd/signaling/tvm300/TVM300toTVM430.kt 42.85% 4 Missing ⚠️
...otlin/fr/sncf/osrd/signaling/tvm430/BALtoTVM430.kt 42.85% 4 Missing ⚠️
...in/fr/sncf/osrd/signaling/tvm430/TVM430toTVM300.kt 42.85% 4 Missing ⚠️
...in/fr/sncf/osrd/signaling/tvm430/TVM430toTVM430.kt 42.85% 4 Missing ⚠️
...va/fr/sncf/osrd/standalone_sim/SignalProjection.kt 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6328      +/-   ##
============================================
+ Coverage     27.66%   27.70%   +0.04%     
- Complexity     2136     2162      +26     
============================================
  Files           990     1000      +10     
  Lines        125902   125907       +5     
  Branches       2575     2578       +3     
============================================
+ Hits          34832    34884      +52     
+ Misses        89580    89534      -46     
+ Partials       1490     1489       -1
Flag Coverage Δ
core 78.66% <61.64%> (-0.22%) ⬇️
editoast 75.59% <100.00%> (+<0.01%) ⬆️
front 8.70% <ø> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <100.00%> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo force-pushed the yk/split-tvm branch 2 times, most recently from 30dcd72 to 20e794d Compare January 11, 2024 16:17
@SarahBellaha SarahBellaha linked an issue Jan 11, 2024 that may be closed by this pull request
Séparation du système TVM: TVM300 et TVM400 #6331
Closed
4 tasks
@Khoyo Khoyo removed a link to an issue Jan 12, 2024
Séparation du système TVM: TVM300 et TVM400 #6331
Closed
4 tasks
@Khoyo Khoyo linked an issue Jan 12, 2024 that may be closed by this pull request
Separate TVM 300 and TVM 430 signaling systems #6282
Closed
@Khoyo Khoyo marked this pull request as ready for review January 12, 2024 08:59
@Khoyo Khoyo requested review from a team as code owners January 12, 2024 08:59
@Khoyo Khoyo requested a review from multun January 12, 2024 08:59
multun
multun approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@multun multun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couldn't do any testing though. It's probably fine since tvm support is a placeholder anyway

@Khoyo
Copy link
Contributor Author

Khoyo commented Jan 12, 2024

Indeed, the split is in preparation for implementing it for real

Erashin
Erashin approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core part lgtm

core/kt-fast-collections-generator/src/main/kotlin/collections/ArrayList.kt Show resolved Hide resolved
shenriotpro
shenriotpro approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for tests/ (impl is not yet ready for actual tests)

flomonster
flomonster approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khoyo Khoyo added this pull request to the merge queue Jan 12, 2024
Merged via the queue into dev with commit e9ac3f3 Jan 12, 2024
20 checks passed
@Khoyo Khoyo deleted the yk/split-tvm branch January 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multun multun multun approved these changes

@flomonster flomonster flomonster approved these changes

@Erashin Erashin Erashin approved these changes

@shenriotpro shenriotpro shenriotpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate TVM 300 and TVM 430 signaling systems
5 participants
@Khoyo @multun @flomonster @Erashin @shenriotpro