Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenApi annotations for views::infra::routes endpoints #6338

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Jan 12, 2024

refs #4580 #3625

@leovalais leovalais added the area:editoast Work on Editoast Service label Jan 12, 2024
@leovalais leovalais requested review from a team as code owners January 12, 2024 12:20
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c9e42f6) 27.90% compared to head (c41873b) 27.91%.

Files Patch % Lines
front/src/common/api/osrdEditoastApi.ts 91.22% 5 Missing ⚠️
...rc/applications/editor/tools/routeEdition/utils.ts 0.00% 3 Missing ⚠️
...lications/editor/tools/pointEdition/components.tsx 0.00% 2 Missing ⚠️
editoast/src/views/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6338      +/-   ##
============================================
+ Coverage     27.90%   27.91%   +0.01%     
  Complexity     2165     2165              
============================================
  Files          1001     1001              
  Lines        126473   126489      +16     
  Branches       2580     2580              
============================================
+ Hits          35296    35314      +18     
+ Misses        89688    89686       -2     
  Partials       1489     1489              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.87% <96.66%> (+0.02%) ⬆️
front 8.70% <83.87%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it and found a bug. We have a 404 missing field infra_id on the endpoint /infra/8/routes/Detector/detecto.XXXXX/

@leovalais leovalais added the area:front Work on Standard OSRD Interface modules label Jan 12, 2024
@leovalais
Copy link
Contributor Author

Oops, thanks good catch 👀

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to wait for the fix of this #6317 to be able to test the changes (will probably cause some conflicts)

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Reviewed + Tested)

@leovalais leovalais added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 16, 2024
- /infra/{infra_id}/routes/{waypoint_type}/{waypoint_id}/
- /infra/{infra_id}/routes/track_ranges/

Also includes a discriminator elimination fix.
@leovalais leovalais added this pull request to the merge queue Jan 16, 2024
Merged via the queue into dev with commit a823c8c Jan 16, 2024
20 checks passed
@leovalais leovalais deleted the lva/openapi-infra-routes branch January 16, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants