Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: actually use PatchMultiplePayload #6378

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Jan 18, 2024

This causes a warning on nightly, remove it before it breaks the build.

This causes a warning on nightly, remove it before it breaks the build.
@Khoyo Khoyo requested a review from a team as a code owner January 18, 2024 07:59
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6efa336) 27.71% compared to head (c74de24) 27.70%.

Files Patch % Lines
editoast/src/views/train_schedule/mod.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6378      +/-   ##
============================================
- Coverage     27.71%   27.70%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1002     1002              
  Lines        126226   126226              
  Branches       2580     2580              
============================================
- Hits          34979    34972       -7     
- Misses        89758    89765       +7     
  Partials       1489     1489              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.72% <33.33%> (-0.04%) ⬇️
front 8.35% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khoyo Khoyo added this pull request to the merge queue Jan 18, 2024
Merged via the queue into dev with commit 80b4da3 Jan 18, 2024
20 checks passed
@Khoyo Khoyo deleted the yk/fix-PatchMultiplePayload-warning branch January 18, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants