Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label for "regular expression" checkbox of text filter not deduplicated #4243

Closed
wetneb opened this issue Oct 23, 2021 · 4 comments · Fixed by #4257 · May be fixed by nikhilp3/OpenRefine#3
Closed

Label for "regular expression" checkbox of text filter not deduplicated #4243

wetneb opened this issue Oct 23, 2021 · 4 comments · Fixed by #4257 · May be fixed by nikhilp3/OpenRefine#3
Assignees
@LENHUTDUY-8120
Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.6

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Oct 23, 2021 •
edited

The labels of the "regular expression" checkboxes are not properly linked to the corresponding checkbox.

To Reproduce

Steps to reproduce the behavior:

  1. First, open a project and create two text filters
  2. Then, click on the label (not the checkbox) "regular expression" in the second text facet

Current Results

bug

Expected Behavior

Clicking on the label should tick/untick the right checkbox.

Versions

  • Operating System: Debian
  • Browser Version: Firefox 78 ESR
  • JRE or JDK Version: 11
  • OpenRefine: 3.5-beta1
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. labels Oct 23, 2021
@LENHUTDUY-8120
Copy link

I'm interested to work on this issue!

@wetneb
Copy link
Sponsor Member Author

wetneb commented Nov 1, 2021

Hi @LENHUTDUY-8120, be my guest! Thanks for volunteering :)

Let me know if you get stuck at any point.

@nikhilp3 nikhilp3 mentioned this issue Nov 1, 2021
Merged
@nikhilp3
Copy link
Contributor

nikhilp3 commented Nov 1, 2021

Hey @LENHUTDUY-8120 sorry didn't see you wanted to work on this until after I submitted a PR. You can take a look at my PR tho and let me know if you think that is the correct way to solve this bug.

@nikhilp3
Copy link
Contributor

nikhilp3 commented Nov 2, 2021

@wetneb do you think this is ready to merge?

@nikhilp3 nikhilp3 mentioned this issue Nov 13, 2021
Open
@wetneb wetneb added this to the 3.6 milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LENHUTDUY-8120 LENHUTDUY-8120

Labels
Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.6
3 participants
@wetneb @LENHUTDUY-8120 @nikhilp3