Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of descriptive message when adding an incorrect schema manifest #4324

Closed
j-sal opened this issue Nov 26, 2021 · 1 comment · Fixed by #4341
Closed

Lack of descriptive message when adding an incorrect schema manifest #4324

j-sal opened this issue Nov 26, 2021 · 1 comment · Fixed by #4341
Labels
error handling Improving the ways errors are reported to users Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@j-sal
Copy link
Contributor

j-sal commented Nov 26, 2021

To Reproduce

Steps to reproduce the behavior:

  1. First, add access the menu in the top right corner 'Extensions: Wikidata' -> 'Select Wikibase instance' -> 'Add Wikibase'
  2. Then, paste/write your manifest containing syntax mistakes (see screenshot)
  3. Finally, select 'Add Wikibase' in the bottom right corner of the window

Current Results

The error "Invalid Wikibase manifest." appears in red letters.

Expected Behavior

A more descriptive error would help narrow down and fix the mistakes.

Screenshots

Issue

Versions

  • Operating System: Ubuntu 18.04
  • Browser Version: Chrome 95
  • JRE or JDK Version: jdk 11
  • OpenRefine: 3.6

Datasets

Extract:
{
"version": "1.0",
"mediawiki": {
"name": "Wikimedia Commons",
"root": "https://commons.wikimedia.org/wiki",
"main_page": "https://commons.wikimedia.org/wiki/Main_Page",
"api": "https://commons.wikimedia.org/w/api.php"
},
//..
"wikibase": {
"site_iri": "https://commons.wikimedia.org/entity",
"maxlag": 5,
"properties": {
"instance_of": "P31",
"subclass_of": "P279",
}
}

Additional context

n/a

@j-sal j-sal added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Nov 26, 2021
@wetneb wetneb added wikibase Related to wikidata/wikibase integration error handling Improving the ways errors are reported to users Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Nov 26, 2021
@wetneb
Copy link
Sponsor Member

wetneb commented Dec 6, 2021

Closed by #4341.

@wetneb wetneb closed this as completed Dec 6, 2021
@wetneb wetneb added this to the 3.6 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error handling Improving the ways errors are reported to users Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants