Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet sidebar shifts when it refreshes #5610

Closed
elebitzero opened this issue Feb 8, 2023 · 1 comment · Fixed by #5611
Closed

Facet sidebar shifts when it refreshes #5610

elebitzero opened this issue Feb 8, 2023 · 1 comment · Fixed by #5611
Assignees
Labels
facets Behaviour or rendering of facets in a project Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@elebitzero
Copy link
Member

elebitzero commented Feb 8, 2023

The issue is as @thadguidry says:

Unneccesary jumping up/down of Facet panels while users click on selections. The div browsing-panel-indicator will quickly show a hidden spinner “Refreshing facets…” which is above the browsing-panel-controls and hence causes all child elements underneath to suddenly move down and then back up. The effect to a user is disconcerting with jerky motion.

image

@elebitzero elebitzero added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 8, 2023
@elebitzero elebitzero self-assigned this Feb 8, 2023
@thadguidry thadguidry added facets Behaviour or rendering of facets in a project Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Feb 8, 2023
@thadguidry
Copy link
Member

thadguidry commented Feb 8, 2023

@elebitzero Thanks for tackling this issue. The question will be where to move this small notice so that users still see it if there is a long running refresh on many facets? I don't even know how to produce such a state. Maybe have many (25-50?) facets with some custom expressions that take a long time to calculate? We also could change the longish test "Refreshing facets..." to just a spinner icon (does Clusterer have one useful to borrow or shrink?) with some alt hover text (so folks can hover on it and know that it is "Refreshing facets...") and place this small icon in the top right or left corner of leftPanelDiv or in lower elements? That way, it could be hidden, and when shown, it wouldn't add a large visible div like now appearing before the facet groups.
https://www.cssscript.com/demo/svg-loading-spinner/
https://github.com/lukehaas/css-loaders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
facets Behaviour or rendering of facets in a project Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants