Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Cypress test in cypress/e2e/create-project/preview_project.cy.js "Tests disabling of automatic preview" #6158

Closed
wetneb opened this issue Nov 15, 2023 · 1 comment · Fixed by #6162
Closed

Flaky Cypress test in cypress/e2e/create-project/preview_project.cy.js "Tests disabling of automatic preview" #6158

wetneb opened this issue Nov 15, 2023 · 1 comment · Fixed by #6162
Assignees
@elebitzero
Labels
tests Improving test coverage and speed Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Nov 15, 2023

The test "Tests disabling of automatic preview" in cypress/e2e/create-project/preview_project.cy.js seems to be flaky as it fails in two PRs with unrelated changes (#6108 and #6156):
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. tests Improving test coverage and speed labels Nov 15, 2023
@wetneb wetneb mentioned this issue Nov 15, 2023
Open
@tfmorris
Copy link
Member

This has been happening for at least a few weeks and is why I added this comment:

OpenRefine/main/tests/cypress/cypress/e2e/create-project/preview_project.cy.js

Line 201 in fb9cd79

cy.waitForImportUpdate(); // This can be flaky, happening too quickly to capture

My theory was that the dialog was being dismissed before the test code was ready to look for it.

@elebitzero elebitzero self-assigned this Nov 16, 2023
@elebitzero elebitzero mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elebitzero elebitzero

Labels
tests Improving test coverage and speed Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
No milestone
3 participants
@tfmorris @wetneb @elebitzero