Make reconciliation errors selectable by facets

[wetneb]

Consider a reconciliation process where some cells could not reconcile properly, resulting in errors stored in cells.
As a user, I want to:

• be notified that those errors happened, without manually scrolling through the dataset to find red text
• be able to easily select all the rows where errors happened, to either fix them manually or re-run reconciliation on this subset only

Proposed solution

Adapt the reconciliation judgment facet to have a new category, "error", corresponding to the cells with a non-null reconciliation error.

This could be done either by changing the expression that defines the facet (such as if(isNonBlank(cell.recon.error), "error", forNonBlank(cell.recon.judgment, v, v, if(isNonBlank(value), "(unreconciled)", "(blank)")))),
or by introducing a new judgment value in the backend. I think the latter would be cleaner.

Alternatives considered

Introduce another facet for that? It seems a bit overkill to me, and would take up more screen space.

Current screenshot

Currently, cells with reconciliation errors have status "none":

After this change, it would look like this instead:

[thadguidry]

@wetneb when you say

or by introducing a new judgment value in the backend. I think the latter would be cleaner.

do you mean a judgment value of "error" ? Can you clarify by adding a bit more detail to that part of the proposal comment?

[wetneb]

We need to add a new Judgment value here ("error") and update the code so that this state is properly set when creating reconciliation with errors:

OpenRefine/main/src/com/google/refine/model/Recon.java

Lines 68 to 73 in ec9c7a4

	static public enum Judgment {
	@JsonProperty("none")
	None, @JsonProperty("matched")
	Matched, @JsonProperty("new")
	New
	}

[thadguidry]

So, we'll be able to facet errors directly. And since we'll have cell.recon.error object, then we can also use that to parse out the error details if we want to?

Also, just wondering if it MIGHT happen that the error object could ever be "empty" and what we will do about that on the backend to avoid giving users on the frontend cluelessness. Because I don't see that avoidance of "empty" only "null" checking happening here: https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/model/Cell.java