Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving renaming columns #6282

Open
cooperzoe opened this issue Jan 4, 2024 · 6 comments
Open

Improving renaming columns #6282

cooperzoe opened this issue Jan 4, 2024 · 6 comments
Labels
Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.

Comments

@cooperzoe
Copy link

When I go to rename a column, I thought it would be easier to click on there column name itself and edit there directly, instead of first going to 'Edit this column' then 'Rename' as pictured in the screenshot below.

I believe that change would be more intuitive from a usability standpoint as well, since I first think of 'Edit this column' as pertaining to the information in the column itself, not its descriptor above.

Screenshot 2024-01-04 at 11 14 38 AM

@cooperzoe cooperzoe added Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. labels Jan 4, 2024
@thadguidry
Copy link
Member

thadguidry commented Jan 4, 2024

I thought we wanted to eventually support "dragging columns" with a click-hold-drag approach. The rename via a click on column header name is sometimes awkward and accidental click/renames can happen as I've seen on other apps. Double-click on column header name might be an option. Depends on how well it's implemented, for example, I like the feel of this example in Edge browser https://developer.mozilla.org/en-US/docs/Web/API/Element/dblclick_event Also on the developer page, there seems to be options for a Ctrl, Shift, Alt, or Meta key was held during firing...which might be preferable for some users that are clicky-happy and don't want accidents. We could make that option for a key held down with double-click as a preference setting. Dunno :-)

@Abbe98
Copy link
Member

Abbe98 commented Jan 4, 2024

I would prefer to have/implement a solution to the menu system being such a pain to navigate/use rather than to see many small approaches to expose features elsewhere in different places.

@wetneb
Copy link
Sponsor Member

wetneb commented Jan 4, 2024

I completely support a bold redesign of this menu (I have something in mind which would essentially get rid of the column menu entirely, related to your extension with a keyboard-based prompt for actions) but I think it is still worth making small changes like this one: if we manage to get rid of "rename column" and "delete column" from this menu into an intuitive UI in the column header itself, that's something that we would likely retain anyway after such a bold redesign: it's two less menu items to replace by similar functionality elsewhere.

@Abbe98
Copy link
Member

Abbe98 commented Jan 4, 2024

I'm still not very fond of the idea of having these small one-off approaches to actions or this particular solution, it would make the UI less consistent and will only increase the existing discovery issues.

@thadguidry
Copy link
Member

The hidden double-click to rename could be approached with an initial large custom tooltip guide, to ensure users are aware of it? I also am not fond of hiding functionality, so I think those would be covered in guides and initial large tooltips that show up when viewing the grid initially and must be dismissed. Facet panel collapse, column rename, column drag, etc.

@tfmorris tfmorris added Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Jan 4, 2024
@tfmorris
Copy link
Member

tfmorris commented Jan 4, 2024

It would probably be worth aligning column rename with project rename so that they use the same design language. I have a small preference for pencil (edit) and X (delete) affordances, but don't feel strongly about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

No branches or pull requests

5 participants