Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source data display for JSON parser #6470

Open
tfmorris opened this issue Mar 19, 2024 · 0 comments
Open

Enable source data display for JSON parser #6470

tfmorris opened this issue Mar 19, 2024 · 0 comments
Labels
JSON JSON as a data import/export format maintainability Making it easier to maintain OpenRefine Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Comments

@tfmorris
Copy link
Member

Currently our Jackson stack traces look like this (from #6464):

com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `com.google.refine.model.Recon`, problem: there is a match hence no error
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1, column: 445]

since this is the users' own data, there's really no need to hide it from them, so I propose that we enable

StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION

Current Results

See above.

Expected Behavior

Jackson shows the offending snippet of user data

@tfmorris tfmorris added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. maintainability Making it easier to maintain OpenRefine Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators JSON JSON as a data import/export format labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON JSON as a data import/export format maintainability Making it easier to maintain OpenRefine Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

No branches or pull requests

1 participant