Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Facet Spinner SOONER on any potentially slow Facets (especially Unicode char-code facet) #6562

Open
thadguidry opened this issue Apr 24, 2024 · 2 comments
Labels
4.0 Specific to the new data processing architecture introduced in 4.0 facets Behaviour or rendering of facets in a project Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Comments

@thadguidry
Copy link
Member

Some of our Facets are especially slow if the size of a project is quite large. The Unicode char-code facet is one such facet that I have come across when using it on a column with 7611 rows, but LOTS of String content in that column; I.E. lots of char()

To Reproduce

Steps to reproduce the behavior:

  1. Load a large dataset with many strings of fairly long length in a column (attached example dataset, Column 3 - "entry - content - div")
  2. In Rows or Record mode, use the Unicode char-code facet on that column
  3. Slide the left handle over towards the right side (for instance, to only filter on rows containing chars greater than char(100)
  4. Notice that the operation seems to start quickly in the console, but the Facet Spinner above (in 4.0 architecture Snapshot) does not show quickly enough, and so the user is left wondering if something is happening for a few seconds, THEN the spinner finally appears for a a few seconds, and then the operation completes.

Current Results

Slow startup of the Facet Spinner even for an operation that has been taking 5-10 seconds, the spinner isn't showing on second 1, but more like second 5 or 7 (some kinda delay?).

Expected Behavior

I don't want to see a delay on the spinner because then after even just 2 or 3 seconds, I am wondering if anything is really happening? I'm already within second 2 or 3 wondering if something is stuck or not or working as expected behind the scenes and it's just taking a while longer. I need the spinner indicator to show up quickly so I know if things are working.

Screenshots

Versions

  • Operating System: Windows 11
  • Browser Version: Edge latest
  • JRE or JDK Version: JDK 21
  • OpenRefine: OpenRefine 4.0 snapshot

Datasets

ES-SDGC-CP-atom-xml.zip

Additional context

@thadguidry thadguidry added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. facets Behaviour or rendering of facets in a project 4.0 Specific to the new data processing architecture introduced in 4.0 labels Apr 24, 2024
@tfmorris
Copy link
Member

This doesn't seem like the kind of thing which would be unique to @wetneb 's branch. Does it work correctly in the current product releases?

BTW, the protocol for this should be:

  1. display the spinner
  2. do the operation
  3. hide the spinner

If it all happens so fast that the user never sees the spinner, all the better.

@thadguidry
Copy link
Member Author

Doesn't happen fast. App UI feels/appears frozen.
I've never seen the spinner on 3.9 from what I can tell.
Would be good to get someone to reproduce this, because I am seeing the issue with my dataset and steps above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 Specific to the new data processing architecture introduced in 4.0 facets Behaviour or rendering of facets in a project Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

No branches or pull requests

2 participants