Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two extensions developed by RefinePro #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wetneb
Copy link
Sponsor Member

@wetneb wetneb commented Nov 1, 2023

I wasn't aware of them but @magdmartin pointed me to them in a call. I think they are worth listing even though they are targeting a fairly old version.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for openrefine-website ready!

Name Link
🔨 Latest commit 09afcb5
🔍 Latest deploy log https://app.netlify.com/sites/openrefine-website/deploys/6542b664898698000879c713
😎 Deploy Preview https://deploy-preview-260--openrefine-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tfmorris
Copy link
Member

tfmorris commented Nov 2, 2023

Should the attribution be to the RefinePro forks or the original FAIRplus repos (e.g. https://github.com/FAIRplus/OpenRefine_Authenticator)? They appear to have been contributed by Novartis (NIBR).

@magdmartin
Copy link
Member

Thanks for adding them @wetneb .

RefinePro was contracted by NIBR to develop extensions, which were then released via FAIRplus. RefinePro added more details to the readme and ported open issues when forking the FAIRplus repositories. It is more likely that any new tickets or pull requests will receive attention on the RefinePro repositories.

@wetneb
Copy link
Sponsor Member Author

wetneb commented Nov 2, 2023

It is more likely that any new tickets or pull requests will receive attention on the RefinePro repositories.

Personally, I would say that the most actively maintained GitHub repository of a project should not be marked as a fork of another one, but as an independent one. You can convert a fork into a non-fork repository by making a request to GitHub's support.

Copy link
Member

@tfmorris tfmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be polite to acknowledge the funder & donor, unless they prefer to remain anonymous, but regardless, I strongly object to these extensions being promoted until their license violations are corrected. They contain entire modules of OpenRefine code, copied verbatim, without any of the required license notices.

For example the only differences in HttpClient.java are changing the package name and adding a single line (although it's also missing all the bug fixes we've made since it was copied).

@wetneb
Copy link
Sponsor Member Author

wetneb commented Nov 8, 2023

It's a valid point, but I would assume good faith here and avoid to scare away the extension author from interacting with the OpenRefine project. I am glad they wrote an extension for OpenRefine and want to encourage them to do more of that.

Looking at the HttpClient.java file, they did make its provenance clear with a comment, so they probably thought they were correctly crediting the original authors by doing that:

/*
    Custom code from original OpenRefine project main/src/com/google/refine/util/HttpClient.java
*/

So I would suspect it's just a lack of familiarity with the concept of license header and the importance to retain them. I think it should be easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants