Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salamandar/audiodev #11

Merged
merged 13 commits into from Aug 30, 2016
Merged

Salamandar/audiodev #11

merged 13 commits into from Aug 30, 2016

Conversation

Salamandar
Copy link
Contributor

Here is a "proper" PR. Added a commit for the cmakelists changes and cmake scripts.

@mdsitton
Copy link
Member

So the issues previously with this PR is:
Please do better commit messages in the future. FSaudio namespace should be changed. Also I don't really want to be using error codes in the codebase so switch the current error code stuff to exceptions. use the logging library in your code as well which is doesn't currently use(though exceptions that wind their way up eventually get automatically logged). Either nuke the SDL_mixer dep or update the CMakeLists.txt to have it required. The other thing is the naming of some stuff is inconsistant with the way i've been moving things to which i can explain to you on gitter if you want.

here was my full comments from gitter:
https://gist.github.com/mdsitton/b49d9412816864392113f18a4b349892

@Salamandar
Copy link
Contributor Author

I keep the PortAudio files "for reference" in case we would want to change back, but we could delete them ;)

@Salamandar
Copy link
Contributor Author

Hop, changed the namespaces ! I wanted to change them while merging master into audiodev, forgot that :p

@mdsitton mdsitton merged commit adadbce into OpenRhythm:master Aug 30, 2016
@mdsitton mdsitton mentioned this pull request Aug 30, 2016
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants