0.17.0-rc2 doesn't build, help2man: can't get `--help' info from ./npa-tool

[zedinosaur]

Expected behaviour

OpenSC builds.

Actual behaviour

Fails, see log below. Tries to use help2man to generate a manpage for npa-tool, but npa-tool doesn't support --help.

Logs

make[5]: Leaving directory '/build/opensc-0.17.0~rc2/src/tools'
/usr/bin/help2man \
        --output=npa-tool.1 \
        --no-info \
        --source='OpenSC 0.17.0' \
        ./npa-tool
help2man: can't get `--help' info from ./npa-tool
Try `--no-discard-stderr' if option outputs to stderr
libtool: link: gcc -pthread -fno-strict-aliasing -g -O2 "-fdebug-prefix-map=/bui
ld/opensc-0.17.0~rc2=." -fstack-protector-strong -Wformat -Werror=format-securit
y -Wall -Wextra -Wno-unused-parameter -Werror=declaration-after-statement -Wl,-z
 -Wl,relro -o .libs/opensc-explorer opensc-explorer.o util.o  -lreadline ../../s
rc/libopensc/.libs/libopensc.so ../../src/common/.libs/libscdl.a ../../src/commo
n/.libs/libcompat.a -ldl -pthread
Makefile:1193: recipe for target 'npa-tool.1' failed
make[4]: *** [npa-tool.1] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory '/build/opensc-0.17.0~rc2/src/tools'
Makefile:433: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/build/opensc-0.17.0~rc2/src'
Makefile:556: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/build/opensc-0.17.0~rc2'
Makefile:465: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/build/opensc-0.17.0~rc2'
dh_auto_build: make -j2 returned exit code 2
debian/rules:4: recipe for target 'build' failed
make: *** [build] Error 2

[Jakuje]

I see the same issue (wondering why it built last time). The problem is that npa-tool does not print help when provided with -h or --help arguments anymore.

[Jakuje]

Since I don't have OpenPACE libraries and header files, the npa-tool builds to nothing. But I have the master which builds without any problems. Only the clean build from the rc2 tarball has this problem for me. I do not see either any significant difference in the configure flags.

[Jakuje]

The referenced commit did not resolve for me the problem of building rc2 release (with this patch applied). I am still seeing the same error:

/usr/bin/help2man \
	--output=npa-tool.1 \
	--no-info \
	--source='OpenSC 0.17.0' \
	./npa-tool
help2man: can't get `--help' info from ./npa-tool
Try `--no-discard-stderr' if option outputs to stderr
Makefile:1192: recipe for target 'npa-tool.1' failed
make[3]: *** [npa-tool.1] Error 1

[frankmorgner]

The commit allows generation of a correct distribution file, which will fix the problem.

git checkout 206b2cec287e63248d781a3f6643e50cb50365f0
autoreconf -vis
./configure
make dist

The generated file opensc-0.17.0.tar.gz will now contain npa-tool.1, which was missing before 206b2ce.

[Jakuje]

Ok, re-creation of the tarball made the build pass for me. Thanks for clarification.