Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong (legacy) IsoApplet version? #2704

Closed
llogar opened this issue Feb 13, 2023 · 2 comments · Fixed by #2710
Closed

Wrong (legacy) IsoApplet version? #2704

llogar opened this issue Feb 13, 2023 · 2 comments · Fixed by #2710

Comments

@llogar
Copy link
Contributor

llogar commented Feb 13, 2023

Shouldn't

OpenSC/src/libopensc/card-isoApplet.c

Line 36 in b53fc5c

#define ISOAPPLET_VERSION_V0 0x0060

be defined as

#define ISOAPPLET_VERSION_V0 0x0006

as the version in IsoApplet.java is/was defined as

/* API Version */
public static final byte API_VERSION_MAJOR = (byte) 0x00;
public static final byte API_VERSION_MINOR = (byte) 0x06;
@Jakuje
Copy link
Member

Jakuje commented Feb 15, 2023

thanks. I missed that @swissbit-csteuer, can you have a look?

@swissbit-csteuer swissbit-csteuer mentioned this issue Feb 15, 2023
Merged
1 task
@swissbit-csteuer
Copy link
Contributor

@llogar is right, it should be 0x0006 and not 0x0060. I created #2710 to address this (+ adding a missing whitespace in the log message 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix isoapplet v0 version check swissbit-eis/OpenSC
3 participants
@Jakuje @llogar @swissbit-csteuer