Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPE Applicability Language #120

Merged
merged 11 commits into from
Feb 7, 2023
Merged

CPE Applicability Language #120

merged 11 commits into from
Feb 7, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Nov 24, 2022

This PR implements parsing of CPE AL.

node_title.appendChild(get_note(`\u00A0\u00A0${node_data.comment}`));
node_text.appendChild(get_label(color, node_data.tag));
node_text.appendChild(get_label(color, node_data.value, get_icon_as_html(icon)));
node_text.appendChild(get_note(`\u00A0\u00A0${node_data.comment ? node_data.comment : ""}`));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not  ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because JavaScript interprets   as a sequence of characters which are escaped for DOM elements. Here is an article about that. There is an option to insert this string as pure HTML into this DOM element, but I'd like to keep an object-oriented approach to the DOM elements.

oval_tree=oval_tree
)],
),
title="System platform of profile",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title="System platform of profile",
title="Profile platform",



class ExceptionNoCPEApplicabilityLanguage(Exception):
"""Raise when there is no CPE Applicability Language"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Raise when there is no CPE Applicability Language"""
"""Raise when there is no CPE Applicability Language platform specification"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants