Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #131

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix issues #131

merged 2 commits into from
Feb 7, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Feb 7, 2023

No description provided.

@@ -23,7 +23,7 @@
def __init__(self, parser): # pylint: disable=W0231
self.report = parser.parse_report()
self.file_loader = FileSystemLoader(str(Path(__file__).parent / "html_templates"))
self.env = Environment(loader=self.file_loader, autoescape=True)
self.env = Environment(loader=self.file_loader)

Check warning

Code scanning / CodeQL

Jinja2 templating with autoescape=False

Using jinja2 templates with autoescape=False can potentially allow XSS attacks.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions and other text with embedded HTML tags aren't displayed correctly. Other cases are escaped directly with the Jinja filter.

Because descriptions and other text with embedded HTML tags aren't displayed correctly. Other cases are escaped directly with the Jinja filter.
@Honny1 Honny1 marked this pull request as ready for review February 7, 2023 16:37
@Honny1 Honny1 merged commit 9500425 into OpenSCAP:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant