Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style adjustments of report #142

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Style adjustments of report #142

merged 4 commits into from
Mar 23, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Mar 13, 2023 •
edited
Loading

This PR brings improvements to the style of the report, such as:

  • Improves wording in the filtering section,
  • Underlines the clickable element of the remediation,
  • Adds a copy button to the clipboard fix of remediation,
  • Allows you to click on the rule title in the rules overview to collapse rule detail. (On hover element is underlined)

Remediation example:
remdiation_example

Rule overview:
image

@Honny1 Honny1 marked this pull request as ready for review March 14, 2023 12:43
evgenyz
evgenyz reviewed Mar 15, 2023
View reviewed changes
openscap_report/report_generators/html_templates/remedations.html Outdated
<span class="pf-c-clipboard-copy__actions">
<span class="pf-c-clipboard-copy__actions-item">
<button id="copy" class="pf-c-button pf-m-plain" type="button" aria-label="Copy to clipboard">
<i class="fas fa-copy" aria-hidden="true"></i> Copy remediation to clipboard!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't yell at the user or get over-exited. Simple [icon] Copy Remediation should be enough.

@evgenyz evgenyz merged commit 2854cfb into OpenSCAP:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenyz evgenyz evgenyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Honny1 @evgenyz