Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the check-fact-ref element in CPE-AL #150

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Mar 29, 2023

This PR adds support for the check-fact-ref element in CPE-AL. And PR fixes a logical test negation parsing problem that was discovered by the new tests.
Fixes: #149

@Honny1 Honny1 marked this pull request as ready for review March 29, 2023 14:40
@Honny1 Honny1 changed the title Add support for check-fact-ref element in CPE-AL Add support for the check-fact-ref element in CPE-AL Mar 29, 2023
@evgenyz
Copy link
Contributor

evgenyz commented Mar 29, 2023

How about adding this element to the test stream? To keep it from breaking.

@Honny1
Copy link
Member Author

Honny1 commented Mar 29, 2023

I'm not sure how to test it elegantly without reproducing the ARF file. I will try to create a test without using another ARF file.

@Honny1 Honny1 marked this pull request as draft March 30, 2023 13:00
@Honny1 Honny1 force-pushed the add-suport-for-element-check-fact-ref branch from f6fd830 to d7666eb Compare March 30, 2023 13:38
@Honny1 Honny1 force-pushed the add-suport-for-element-check-fact-ref branch from d7666eb to 0cdc7f0 Compare March 30, 2023 13:42
@Honny1 Honny1 marked this pull request as ready for review April 4, 2023 18:29
@Honny1
Copy link
Member Author

Honny1 commented Apr 4, 2023

@evgenyz Tests have been added. Plánuji vytvořit velký integrační test v jiném PR.

@evgenyz
Copy link
Contributor

evgenyz commented Apr 4, 2023

@evgenyz Tests have been added. Plánuji vytvořit velký integrační test v jiném PR.

Dobře.

@evgenyz evgenyz merged commit 89eb900 into OpenSCAP:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback when generating report from Automatus
2 participants