Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #151

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Integration tests #151

merged 7 commits into from
Apr 13, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Apr 5, 2023

This PR creates a set of integration tests using the tmt tool, a script that generates ARF reports with different configurations, modifies the smoke test to use the given ARF file, and creates a GitHub action to run these integration tests weekly.

The tests use ARF results generated with the latest content available as an SSG package and content from the ComplianceAsCode/content repository.

Some integration tests could have failed because the test used the latest released openscap-report package. The goal is to check the released package of openscap-repot is behave right with changes in content in ComplianceAsCode/content and with shipped content in the SSG package.

The integration test could be executed in Tesitng Farm with PackIt. It would need some adjustments to the content product. In Testing Farm could be provided RPM package from changes in PR. Execution of this test in Testing Farm takes about 30min.

That's why I decided to run the integration test scheduled with GitHub Actions. I think using these tests for changes in PR would be pointless.

@Honny1 Honny1 marked this pull request as ready for review April 6, 2023 09:53
@Honny1 Honny1 marked this pull request as draft April 6, 2023 09:54
@Honny1 Honny1 force-pushed the integration-tests branch 2 times, most recently from 366e9a7 to 17514e6 Compare April 6, 2023 12:03
@Honny1 Honny1 marked this pull request as ready for review April 6, 2023 12:37
- name: Generate ARF files
how: shell
script:
- ./generate_arf.sh ssg no fedora ${TMT_PLAN_DATA}/arf.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we parametrize the product?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or it should be marked as only executable in Fedora.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be parameterized, but how do we determine which product to use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FMF must somehow provide the name of the platform is it trying to execute the test on. We might need to map FMF name to our product name, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an idea of how to map the distro value to product value.

@Honny1
Copy link
Member Author

Honny1 commented Apr 13, 2023

Changes:

  • Product of content is set according to the distro.

@Honny1 Honny1 requested a review from evgenyz April 13, 2023 14:12
@evgenyz evgenyz merged commit 9bf22e8 into OpenSCAP:main Apr 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants