Implement clear button for search bar #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyz
reviewed
Jun 20, 2023
| self.previousSibling.value= ""; | ||
| search_rule(self.previousSibling); | ||
| } |
There was a problem hiding this comment.
Probably yes, I use eslint to check javascript files and the default is forced without a newline. I've read the documentation for the eol-last rule, and it doesn't explain any specific purpose or benefit of not having a newline at the end of the file. So I'll use the Unix conversion and fix the newlines and update the line settings in another PR.
Honny1
force-pushed
the
add-clear-button-to-search-bar
branch
from
c7eeedb
to
a3b5acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a clear button to the search bar.
Fixes: #179