Add target addresses #220
Merged
Add target addresses #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
reviewed
Jan 24, 2024
| <li class="pf-c-data-list__item"> | ||
| <div class="pf-c-data-list__item-row"> | ||
| <div class="pf-c-data-list__item-content"> | ||
| <div class="pf-c-data-list__cell"><b>Target {{ type }} addresses:</b></div> |
There was a problem hiding this comment.
It would be better if you used the correct orthography of these acronyms, ie. MAC, IPv4, IPv6 instead of mac, ipv4, ipv6.
There was a problem hiding this comment.
Ok, here is the fixed version.
|
Hello @Honny1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Honny1
force-pushed
the
add-target-ips
branch
from
d1330ee
to
1c7968e
Compare
jan-cerny
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds target addresses to the report.
Fixes: #165