Reorganization of OVAL Test results #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
reviewed
Jan 24, 2024
| return body; | ||
| } | ||
|
|
||
| function generate_referenced_endpoints(test_info, children_id, div) { |
There was a problem hiding this comment.
Consider if the code complexity of this function can be reduced, for example by inverting the condition or extracting the inner for loop to a separate function.
Comment on lines
92
to
95
| if data_id not in map_referenced_oval_endpoints: | ||
| map_referenced_oval_endpoints[data_id] = [] | ||
| if value not in map_referenced_oval_endpoints[data_id]: | ||
| map_referenced_oval_endpoints[data_id].append(value) |
There was a problem hiding this comment.
Can the map be a collections.defaultdict? I think that would help you avoid this construction.
jan-cerny
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the representation of components referenced by OVAL Tests, such as Objects, States, and Variables.
See the new representation:
Fixes: #216