Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search rules by references #224

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jan 26, 2024

This PR adds the ability to search rules by reference and policy. It also adds help with tips for using search and advanced search options.

image

Fixes:

@pep8speaks
Copy link

pep8speaks commented Jan 26, 2024

Hello @Honny1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-26 13:00:43 UTC

@Honny1 Honny1 marked this pull request as ready for review January 26, 2024 13:20
@Honny1 Honny1 requested a review from jan-cerny January 26, 2024 13:20
@jan-cerny jan-cerny self-assigned this Jan 26, 2024
@jan-cerny jan-cerny changed the title Search rules by referneces Search rules by references Jan 26, 2024
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have generated a report from a scan that used a SCAP source data stream from the latest upstream master as of 2024-01-26 and then I tried to use this feature. Rule filtering and filtering by references worked nicely. I think it's a great improvement. Now we should think how to increase the UX and discoverability of this feature.

@jan-cerny jan-cerny merged commit d91656d into OpenSCAP:main Jan 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More Visible Advanced Filtering Options Filter Rules by References
3 participants