Make openscap-report compatible with Python 3.6 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.6, which is the default Python in RHEL 8, doesn't provide the `dataclasses` module, this module has been introduced in Python 3.8. To make the class work, we will bundle this module. Imported from: https://github.com/ericvsmith/dataclasses/blob/master/dataclasses.py
|
Hello @jan-cerny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-22 15:51:47 UTC |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This commit introduces changes necessary to make our code compatbile with Python 3.6, the default Python version shipped in RHEL 8. The most important changes are: - using bundled dataclasses if not available - do not use contextlib.nullcontext - do not use importlib.metadata
This change should make the test environment similar to RHEL 8 where the Python 3.6 is used as default.
Build with the default Python 3 (Python 3.6). Builiding with Python 3.8 is possible in EPEL but not for CS 8 where the default module must be used.
Honny1
requested changes
Apr 22, 2024
openscap_report/dataclasses.py
Outdated
There was a problem hiding this comment.
I recommend placing this file in a new dataclasses directory with the file __init__.py, where the import of internal dataclasses or those provided by Python will be processed. Then you will be able to simplify imports in other files and reduce code duplication.
Please try to solve the Linters problem. I recommend formatting the code with black and sorting the imports with isort.
This helps simplify the import statements in individual files.
Honny1
reviewed
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSCAP Report currently supports Python 3.8 and newer. However, the default version in RHEL 8 is Python 3.6. This PR introduces changes necessary to make our code compatible with Python 3.6.
The most important changes are: