Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change local and remote file system detection #1573

Merged
merged 3 commits into from Aug 19, 2020

Commits on Aug 18, 2020

  1. Change local and remote file system detection

    The previous way was unreliable because some remote file systems were
    detected as local. For example, the SMB mounts that used paths with
    backslashes were not recognized as remote file systems.  The `getmntent`
    function returns a file system type, so we can use it for detection of
    remote file systems.
    
    The new solution is inspired by systemd, function `fstype_is_network`:
    https://github.com/systemd/systemd/blob/21fd6bc263f49b57867d90d2e1f9f255e5509134/src/basic/mountpoint-util.c#L290
    
    It also handles FUSE file systems. Also, we are canceling the TODO idea
    of providing the data at the build time and removing the dead code (if
    0).
    
    Resolves: RHBZ#1869195
    jan-cerny committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    6909a72 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Add a comment

    that points out to the original source for reference
    jan-cerny committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    5806765 View commit details
    Browse the repository at this point in the history
  2. Treat GPFS as remote system

    This link indicates that gpfs is the right type string:
    https://www.ibm.com/developerworks/systems/library/es-gpfs/index.html
    
    Resolves: RHBZ#1840575, RHBZ#1840578
    jan-cerny committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1541487 View commit details
    Browse the repository at this point in the history