Enable compressed feeds, and ability to debug them for 1.2 #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching remote resources, some servers/CDNs may be able to serve us compressed http response even in cases when the original file is not compressed XML. libcurl is able to process encoded html for us with no added maintenance costs. Attached please find a CURL log of fetching plain XML file from Red Hat CDN: Downloading: https://www.redhat.com/security/data/oval/com.redhat.rhsa-RHEL7.xml ... * Trying 104.90.105.254:443... * Connected to www.redhat.com (104.90.105.254) port 443 (#0) * ALPN, offering h2 * ALPN, offering http/1.1 * successfully set certificate verify locations: * CAfile: /etc/pki/tls/certs/ca-bundle.crt CApath: none * SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384 * ALPN, server accepted to use h2 * Server certificate: * subject: businessCategory=Private Organization; jurisdictionC=US; jurisdictionST=Delaware; serialNumber=2945436; C=US; ST=North Carolina; L=Raleigh; O=Red Hat, Inc.; CN=www.redhat.com * start date: Feb 24 00:00:00 2020 GMT * expire date: May 24 12:00:00 2022 GMT * subjectAltName: host "www.redhat.com" matched cert's "www.redhat.com" * issuer: C=US; O=DigiCert Inc; OU=www.digicert.com; CN=DigiCert SHA2 Extended Validation Server CA * SSL certificate verify ok. * Using HTTP2, server supports multi-use * Connection state changed (HTTP/2 confirmed) * Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0 * Using Stream ID: 1 (easy handle 0x776c3b0) > GET /security/data/oval/com.redhat.rhsa-RHEL7.xml HTTP/2 Host: www.redhat.com accept: */* accept-encoding: gzip * old SSL session ID is stale, removing * Connection state changed (MAX_CONCURRENT_STREAMS == 100)! < HTTP/2 200 < server: Apache < last-modified: Wed, 08 Jul 2020 12:41:28 GMT < etag: "7f694279-fca5e0-5a9ed6d376a08" < accept-ranges: bytes < content-type: text/xml < content-encoding: gzip < content-length: 1766376 < date: Wed, 08 Jul 2020 13:15:29 GMT < vary: Accept-Encoding < strict-transport-security: max-age=31536000 < * Connection #0 to host www.redhat.com left intact
matejak
changed the title
matejak
force-pushed
the
feed_compression
branch
from
813484a
to
bb0cf9d
Compare
…BUGFUNCTION Adds a request for compressed Transfer Encoding in the outgoing HTTP request. If the server supports this and so desires, it can respond with the HTTP response sent using a compressed Transfer-Encoding that will be automatically uncompressed by libcurl on reception. The CURLOPT_DEBUGFUNCTION callback is used for printing headers and connection information on VERBOSE level (dD).
matejak
force-pushed
the
feed_compression
branch
from
bb0cf9d
to
5c823e6
Compare
oscap 1.2 is picky about the --verbose option position.
|
Some issues with CI are expected:
|
jan-cerny
reviewed
Aug 21, 2020
|
|
||
| set -e -o pipefail | ||
|
|
||
| . $builddir/tests/test_common.sh |
There was a problem hiding this comment.
Try to use relative path instead of $builddir/tests
Suggested change
| . $builddir/tests/test_common.sh | |
| . ../test_common.sh |
There was a problem hiding this comment.
This is not the case - the test passes on RHEL8, but didn't pass on RHEL7, because the version requirement was too strict.
I have written another check, so let's see how it works out.
matejak
force-pushed
the
feed_compression
branch
from
aa6f3a8
to
ed03d5a
Compare
via the CURLOPT_ACCEPT_ENCODING option.
matejak
force-pushed
the
feed_compression
branch
from
ed03d5a
to
a95e6d1
Compare
jan-cerny
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is port of #1557, #1561 and #1564 to the maint-1.2 branch.