Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #272: XCCDF rule unscored role is not working #276

Merged
merged 2 commits into from
Jan 11, 2016
Merged

Issue #272: XCCDF rule unscored role is not working #276

merged 2 commits into from
Jan 11, 2016

Conversation

jan-cerny
Copy link
Member

A rule with unscored role should not be counted in score.
XCCDF sepcification says about xccdf:Rule/@ROLE="unscored":
if the rule is selected, then check it and include the results in
any report, but do not include the result in score computations.
This pull request fixes counting scores to be in line with specification.
This pull request also adds test tests counting scores of rules with role attribute set
to "unscored" on all 4 scoring models.

@jan-cerny
Issue OpenSCAP#272: XCCDF rule unscored role is not working
159ae90 
A rule with unscored role should not be counted in score.
XCCDF sepcification says about xccdf:Rule/@ROLE="unscored":
if the rule is selected, then check it and include the results in
any report, but do not include the result in score computations.
This commit fixes counting scores to be in line with specification.
@jan-cerny
Add a test for issue OpenSCAP#272
2ec1753 
This test tests counting scores of rules with role attribute set
to "unscored" on all 4 scoring models.
@jan-cerny
Copy link
Member Author

[test this please]

@isimluk
Copy link
Member

isimluk commented Dec 22, 2015

selinuxboolean test fails on f22 slave. Any idea?

@jan-cerny
Copy link
Member Author

@isimluk I am going to have a look at this now.
EDIT: it looks like that unfortunately I can't connect to ssh from my home network, so I am not able to check it now.
According to the git log, we haven't made any changes to the selinuxboolean test recently.
I am very eager to find out whether this test is not deterministics and why.

@jan-cerny jan-cerny mentioned this pull request Jan 4, 2016
Closed
@isimluk
Copy link
Member

isimluk commented Jan 8, 2016

@openscap-jenkins [test this please]
@ybznek Can you please debug with @jan-cerny, why he cannot access the slave? :-)

@isimluk isimluk self-assigned this Jan 8, 2016
@isimluk
Copy link
Member

isimluk commented Jan 8, 2016

test this please

@isimluk
Copy link
Member

isimluk commented Jan 8, 2016

This is weird. There are two tests. When I ask jenkins it re-runs the default test. But it does not run any tests it just does make dist or something. How do I re-run openscap-pull-requests?

@isimluk
Copy link
Member

isimluk commented Jan 11, 2016

I just re-run the tests locally and re-reviewed. Everything is fine.

I am sorry it took so long.

isimluk added a commit that referenced this pull request Jan 11, 2016
@isimluk
Merge pull request #276 from jan-cerny/issue272
556aa22 
 Issue #272: XCCDF rule unscored role is not working
@isimluk isimluk merged commit 556aa22 into OpenSCAP:maint-1.0 Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@isimluk isimluk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-cerny @isimluk