Fix export of overrided oscap_text #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows attributes marked as overriders by oscap_text_set_override() to be exported. Exportation of an overrider attribute is conditioned by override_given. But override_given is only set when an imported attribute has override capability set. So, when an oscap_text was marked as overrider by oscap_text_set_set_override() the attribute was never exported. Related to RHBZ#1320194.
|
Makes sense to me. The worst that can happen here is that we export the attribute when not necessary and that is not a major problem. ACK but will wait for Jenkins. |
|
I think the test file in parser unit test needs to be changed, override=false needs to be added so that the exported is exactly the same as imported. Then it should pass. |
Export override attribute of oscap_text only when the element can override parent value and it does override the value. The default value for override is false, there is no need to export it if it`s false.
|
Restricted the export of override attribute to true values only. There is no need to export override="false". |
|
OK, ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows attributes marked as overriders by
oscap_text_set_override() to be exported.
Exportation of an overrider attribute is conditioned by override_given.
But override_given is only set when an imported attribute has override
capability set. So, when an oscap_text was marked as overrider by
oscap_text_set_set_override() the attribute was never exported.
Related to RHBZ#1320194.