Fix some corner-case file descriptor leaks

Credits to @ryancaicse for the analysis and report in #2714 (cherry picked from commit 3ca4d8c)
OpenSIPS · Jan 7, 2022 · 0019f55 · 0019f55
1 parent ab5f0f8
commit 0019f55
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/menuconfig/parser.c b/menuconfig/parser.c
@@ -365,6 +365,7 @@ int parse_defs_m4(select_menu *curr_menu,cfg_gen_t *curr_cfg)
 
 		if (parse_defs_m4_line(p,curr_menu) < 0) {
 			fprintf(output,"Failed to parse m4 line [%s]\n",p);
+			fclose(f);
 			return -1;
 		}
 	}

diff --git a/utils/db_berkeley/bdb_recover.c b/utils/db_berkeley/bdb_recover.c
@@ -331,6 +331,7 @@ int recover(char* jfn)
 	{
 		fprintf(stderr, "[recover]: Table %s is not supported.\n",tn);
 		fprintf(stderr, "[recover]: FAILED to load journal file: %s.\n", jfn);
+		fclose(fp);
 		return 2;
 	}
 
@@ -339,6 +340,7 @@ int recover(char* jfn)
 	if(!tbc || !tp)
 	{
 		fprintf(stderr, "[recover]: FAILED to get find metadata for : %s.\n", tn);
+		fclose(fp);
 		return 3;
 	}