t_newtran() automatically sends a 100 Tryting for INVITE.

TO have a consistent behavior between:
	t_newtran();
	t_relay();
and
	t_relay();

(where in the first case a 100 Trying will not be auto generated), we do not sent the 100 Trying on r_relay (when transaction is built) but on t_newtan().
Reported by MAxim Sobolev.

(cherry picked from commit 0db7789)

modules/b2b_entities/dlg.c

@@ -486,7 +486,6 @@ int b2b_prescript_f(struct sip_msg *msg, void *uparam)
 	str param= {NULL,0};
 	b2b_table table = NULL;
 	int method_value;
-	static str reason = {"Trying", 6};
 	str from_tag;
 	str to_tag;
 	str callid;
@@ -883,12 +882,6 @@ int b2b_prescript_f(struct sip_msg *msg, void *uparam)
 			if(tm_tran && tm_tran!=T_UNDEFINED)
 				tmb.unref_cell(tm_tran);
 		}
-
-		/* send provisional reply 100 Trying */
-		if(method_value == METHOD_INVITE)
-		{
-			tmb.t_reply(msg, 100, &reason);
-		}
 	}
 
 	b2b_cback = dlg->b2b_cback;

modules/b2b_entities/server.c

@@ -52,7 +52,6 @@ str* server_new(struct sip_msg* msg, str* local_contact,
 {
 	b2b_dlg_t* dlg;
 	unsigned int hash_index;
-	static str reason = {"Trying", 6};
 	int ret;
 
 	if(param && param->len > B2BL_MAX_KEY_LEN)
@@ -94,8 +93,6 @@ str* server_new(struct sip_msg* msg, str* local_contact,
 		dlg->uas_tran = tmb.t_gett();
 	}
 	tmb.ref_cell(dlg->uas_tran);
-
-	tmb.t_reply(msg, 100, &reason);
 	tmb.t_setkr(REQ_FWDED);
 
 	LM_DBG("new server entity[%p]: callid=[%.*s] tag=[%.*s] param=[%.*s] dlg->uas_tran=[%p]\n",

modules/cpl-c/cpl_proxy.h

@@ -297,7 +297,6 @@ static inline char *run_proxy( struct cpl_interpreter *intr )
 	int timeout;
 	str *s;
 	struct location *loc;
-	str reason;
 
 	intr->proxy.ordering = PARALLEL_VAL;
 	intr->proxy.recurse = (unsigned short)cpl_env.proxy_recurse;
@@ -460,17 +459,6 @@ static inline char *run_proxy( struct cpl_interpreter *intr )
 				return EO_SCRIPT;
 			}
 			intr->flags |= CPL_IS_STATEFUL;
-
-			/* INVITE processing might take long, particularly because of DNS
-			 * look-ups -- let upstream know we're working on it  */
-			if ( intr->msg->REQ_METHOD==METHOD_INVITE ) {
-				reason.s = "Trying";
-				reason.len = 6;
-				if (cpl_fct.tmb.t_reply(intr->msg, (int)100, &reason) != 1) {
-					LM_ERR("100 t_reply failed!\n");
-					goto runtime_error;
-				}
-			}
 		}
 
 		/* as I am interested in getting the responses back - I need to install

modules/seas/seas.c

@@ -247,7 +247,6 @@ static int w_as_relay_t(struct sip_msg *msg, char *entry, char *foo)
    char *buffer,processor_id;
    struct cell *mycel;
    struct as_entry *as;
-   static str msg100={"Your call is important to us",sizeof("Your call is important to us")-1};
    static str msg500={"Server Internal Error!",sizeof("Server Internal Error!")-1};
 
    buffer=(char*)0;
@@ -268,15 +267,6 @@ static int w_as_relay_t(struct sip_msg *msg, char *entry, char *foo)
       ret = 0;
       goto done;
    }
-   /*new transaction created, let's pass it to an APP SERVER*/
-   if (msg->REQ_METHOD==METHOD_INVITE )
-   {
-      LM_DBG("new INVITE\n");
-      if(!seas_f.tmb.t_reply(msg,100,&msg100)){
-	 LM_DBG("t_reply (100)\n");
-	 goto error;
-      }
-   }
    as=(struct as_entry *)entry;
    if(!as->connected){
       LM_ERR("app server %.*s not connected\n",as->name.len,as->name.s);

modules/tm/t_funcs.c

@@ -54,8 +54,6 @@
 #include "config.h"
 #include "../../context.h"
 
-static str relay_reason_100 = str_init("Giving a try");
-
 
 /* ----------------------------------------------------- */
 int send_pr_buffer( struct retr_buf *rb, void *buf, int len,
@@ -185,7 +183,6 @@ int t_relay_to( struct sip_msg  *p_msg , struct proxy_l *proxy, int flags)
 	int new_tran;
 	int reply_ret;
 	struct cell *t;
-	context_p ctx_backup;
 
 	ret=0;
 
@@ -233,16 +230,6 @@ int t_relay_to( struct sip_msg  *p_msg , struct proxy_l *proxy, int flags)
 	if (flags&TM_T_REPLY_nodnsfo_FLAG) t->flags|=T_NO_DNS_FAILOVER_FLAG;
 	if (flags&TM_T_REPLY_reason_FLAG) t->flags|=T_CANCEL_REASON_FLAG;
 
-	/* INVITE processing might take long, particularly because of DNS
-	   look-ups -- let upstream know we're working on it */
-	if ( p_msg->REQ_METHOD==METHOD_INVITE &&
-	!(flags&(TM_T_REPLY_no100_FLAG|TM_T_REPLY_repl_FLAG)) ) {
-		ctx_backup = current_processing_ctx;
-		current_processing_ctx = NULL;
-		t_reply( t, p_msg , 100 , &relay_reason_100);
-		current_processing_ctx = ctx_backup;
-	}
-
 	/* now go ahead and forward ... */
 	ret=t_forward_nonack( t, p_msg, proxy);
 	if (ret<=0) {

modules/tm/t_lookup.c

@@ -145,6 +145,8 @@ static struct cell *cancelled_T;
  */
 static struct cell *e2eack_T;
 
+static str relay_reason_100 = str_init("Giving a try");
+
 
 struct cell *get_t(void) { return T; }
 void set_t(struct cell *t) { T=t; }
@@ -1002,6 +1004,7 @@ static inline int new_t(struct sip_msg *p_msg, int full_uas)
 int t_newtran( struct sip_msg* p_msg, int full_uas )
 {
 	int lret, my_err;
+	context_p ctx_backup;
 
 	/* is T still up-to-date ? */
 	LM_DBG("transaction on entrance=%p\n",T);
@@ -1102,6 +1105,13 @@ int t_newtran( struct sip_msg* p_msg, int full_uas )
 		return E_BAD_VIA;
 	}
 
+	if (p_msg->REQ_METHOD==METHOD_INVITE) {
+		ctx_backup = current_processing_ctx;
+		current_processing_ctx = NULL;
+		t_reply( T, p_msg , 100 , &relay_reason_100);
+		current_processing_ctx = ctx_backup;
+	}
+
 	return 1;
 new_err:
 	UNLOCK_HASH(p_msg->hash_index);