event_xmlrpc: only retry send/recv a couple of times if there are errors

Credits go to Joseph Frazier (onsip) for spotting this
OpenSIPS · Jun 2, 2015 · 05bc754 · 05bc754
1 parent 008b423
commit 05bc754
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/modules/event_xmlrpc/xmlrpc_send.c b/modules/event_xmlrpc/xmlrpc_send.c
@@ -91,8 +91,7 @@ int xmlrpc_send(xmlrpc_send_t* xmlrpcs)
 
 	do {
 		rc = write(xmlrpc_pipe[1], &xmlrpcs, sizeof(xmlrpc_send_t *));
-	} while ((rc < 0 && (IS_ERR(EINTR)||IS_ERR(EAGAIN)||IS_ERR(EWOULDBLOCK)))
-			|| retries-- > 0);
+	} while (rc < 0 && (IS_ERR(EINTR) || retries-- > 0));
 
 	if (rc < 0) {
 		LM_ERR("unable to send xmlrpc send struct to worker\n");
@@ -114,7 +113,7 @@ static xmlrpc_send_t * xmlrpc_receive(void)
 
 	do {
 		rc = read(xmlrpc_pipe[0], &recv, sizeof(xmlrpc_send_t*));
-	} while ((rc < 0 && IS_ERR(EINTR)) || retries-- > 0);
+	} while (rc < 0 && (IS_ERR(EINTR) || retries-- > 0));
 
 	if (rc < 0) {
 		LM_ERR("cannot receive send param\n");