Skip to content

Commit

Permalink
pua_mi: fix parameter name in pua_subscribe MI command
Browse files Browse the repository at this point in the history
Also improve the docs for pua_subscribe by adding an usage example
and proper indexing.

(cherry picked from commit 0d20cd5)
  • Loading branch information
rvlad-patrascu committed Nov 13, 2020
1 parent ad5f74e commit 0c9b1ff
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
19 changes: 14 additions & 5 deletions modules/pua_mi/doc/pua_mi_admin.xml
Expand Up @@ -79,9 +79,9 @@ modparam("pua_mi", "presence_server", "sip:pa@opensips.org:5075")
<para>The module does not export functions to be used
in configuration script.</para>
</section>
<section>
<section id="exported_mi_functions" xreflabel="Exported MI Functions">
<title>Exported MI functions</title>
<section>
<section id="mi_pua_publish" xreflabel="pua_publish">
<title>
<function moreinfo="none">pua_publish</function>
</title>
Expand Down Expand Up @@ -153,8 +153,7 @@ opensips-cli -x mi pua_publish sip:system@opensips.org 3600 presence application
</example>
</section>

</section>
<section>
<section id="mi_pua_subscribe" xreflabel="pua_subscribe">
<title>
<function moreinfo="none">pua_subscribe</function>
</title>
Expand All @@ -177,7 +176,7 @@ opensips-cli -x mi pua_publish sip:system@opensips.org 3600 presence application

<listitem>
<para>
<emphasis>event package</emphasis>
<emphasis>event_package</emphasis>
</para>
</listitem>
<listitem>
Expand All @@ -187,6 +186,16 @@ opensips-cli -x mi pua_publish sip:system@opensips.org 3600 presence application
</para>
</listitem>
</itemizedlist>
<example>
<title><function>pua_subscribe</function> FIFO example</title>
<programlisting format="linespecific">
...
<![CDATA[
opensips-cli -x mi pua_subscribe sip:system@opensips.org sip:400@opensips.org presence 3600
]]>
</programlisting>
</example>
</section>
</section>
</chapter>

2 changes: 1 addition & 1 deletion modules/pua_mi/mi_func.c
Expand Up @@ -434,7 +434,7 @@ mi_response_t *mi_pua_subscribe(const mi_params_t *params,
return init_mi_error(400, MI_SSTR("Bad uri"));
}

if (get_mi_string_param(params, "event",
if (get_mi_string_param(params, "event_package",
&event.s, &event.len) < 0)
return init_mi_param_error();

Expand Down

0 comments on commit 0c9b1ff

Please sign in to comment.