call va_end() on all paths

OpenSIPS · Jan 18, 2016 · 11a97f4 · 11a97f4
1 parent 0cc05e0
commit 11a97f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/modules/ldap/ldap_api_fn.c b/modules/ldap/ldap_api_fn.c
@@ -188,6 +188,7 @@ int ldap_params_search_async(
 	va_start(filter_vars, _filter);
 	rc = vsnprintf(filter_str, (size_t)LDAP_MAX_FILTER_LEN, _filter,
 			filter_vars);
+	va_end(filter_vars);
 	if (rc >= LDAP_MAX_FILTER_LEN)
 	{
 		LM_ERR(	"[%s]: filter string too long (len [%d], max len [%d])\n",
@@ -280,6 +281,7 @@ int ldap_params_search(
 	va_start(filter_vars, _filter);
 	rc = vsnprintf(filter_str, (size_t)LDAP_MAX_FILTER_LEN, _filter,
 			filter_vars);
+	va_end(filter_vars);
 	if (rc >= LDAP_MAX_FILTER_LEN)
 	{
 		LM_ERR(	"[%s]: filter string too long (len [%d], max len [%d])\n",

diff --git a/modules/lua/sipluafunc.c b/modules/lua/sipluafunc.c
@@ -51,15 +51,17 @@ void siplua_log(int lev, const char *format, ...)
   va_list ap;
   char *ret;
   int priority;
+  int rc;
 
   if (!format)
     return;
   if (!(is_printable(lev) | lua_user_debug))
     return;
   va_start(ap, format);
-  if (vasprintf(&ret, format, ap) < 0)
-    return;
+  rc = vasprintf(&ret, format, ap);
   va_end(ap);
+  if (rc < 0)
+    return;
   LM_GEN1(lev, "siplua: %s", ret);
   if (lua_user_debug)
     {