usrloc: Remove bogus "unsused" parameter to MI 'ul_add'; Improve docs

modules/usrloc/doc/usrloc_admin.xml

@@ -1567,38 +1567,36 @@ modparam("usrloc", "contact_refresh_timer", true)
 		<para>Parameters: </para>
 		<itemizedlist>
 			<listitem><para>
-				<emphasis>table name</emphasis> - table where the contact
-				will be added (Ex: location).
+				<emphasis>table name (string)</emphasis> - table where the contact
+				will be added (Ex: "location").
 			</para></listitem>
 			<listitem><para>
-				<emphasis>aor</emphasis> - user AOR in username[@domain]
+				<emphasis>aor (string) </emphasis> - user AOR in username[@domain]
 				format (domain must be supplied only if use_domain option
 				is on).
 			</para></listitem>
 			<listitem><para>
-				<emphasis>contact</emphasis> - contact string to be added
-			</para></listitem>
-			<listitem><para>
-				<emphasis>expires</emphasis> - expires value of the contact
+				<emphasis>contact (string)</emphasis> - Contact URI to be added
 			</para></listitem>
 			<listitem><para>
-				<emphasis>q</emphasis> - Q value of the contact
+				<emphasis>expires (int)</emphasis> - expires value of the contact
 			</para></listitem>
 			<listitem><para>
-				<emphasis>unused</emphasis> - unused attribute (kept for
-				backword compatibility)
+				<emphasis>q (string)</emphasis> - Q value of the contact
 			</para></listitem>
 			<listitem><para>
-				<emphasis>flags</emphasis> - internal USRLOC flags of the
+				<emphasis>flags (int)</emphasis> - internal USRLOC flags of the
 				contact
 			</para></listitem>
 			<listitem><para>
-				<emphasis>cflags</emphasis> - per branch flags of the
+				<emphasis>cflags (int)</emphasis> - per branch flags of the
 				contact
 			</para></listitem>
 			<listitem><para>
-				<emphasis>methods</emphasis> - mask with supported requests
-				of the contact
+				<emphasis>methods (int)</emphasis> - bitmask with supported requests
+				of the contact.  To whitelist all SIP methods, simply use the
+				value <emphasis role='bold'>32767</emphasis>. For a breakdown
+				of each method's value, see the "request_method" internal enum.
 			</para></listitem>
 		</itemizedlist>
 	</section>

modules/usrloc/ul_mod.c

@@ -271,7 +271,7 @@ static const mi_export_t mi_cmds[] = {
 	},
 	{ MI_USRLOC_ADD, 0, 0, mi_child_init, {
 		{mi_usrloc_add, {"table_name", "aor", "contact", "expires", "q",
-						 "unsused", "flags", "cflags", "methods", 0}},
+						 "flags", "cflags", "methods", 0}},
 		{EMPTY_MI_RECIPE}}
 	},
 	{ MI_USRLOC_SHOW_CONTACT, 0, 0, mi_child_init, {
@@ -404,7 +404,7 @@ static int mod_init(void)
 }
 
 
-static void ul_rpc_data_load(int sender_id, void *unsused)
+static void ul_rpc_data_load(int sender_id, void *_)
 {
 	dlist_t* ptr;