Fix a pkg memory leak: when parsing of the Contact fails, free

all associated parameters that have been parsed so far, not just the contact structure itself. Reported by OSS-Fuzz.
OpenSIPS · Mar 20, 2023 · 389caf3 · 389caf3
1 parent 4f929bd
commit 389caf3
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/parser/contact/contact.c b/parser/contact/contact.c
@@ -271,14 +271,13 @@ int parse_contacts(str* _s, contact_t** _c)
 	}
 
  error:
-	if (c) pkg_free(c);
+	if (c) free_contacts(&c);
 	free_contacts(_c); /* Free any contacts created so far */
 	return -1;
 
  ok:
 	c->len = _s->s - c->name.s;
 	if (last) {last->next=c;} else {*_c = c;}
-	last = c;
 	return 0;
 }