Skip to content

Commit

Permalink
acc: Fix incorrect Request-URI handling
Browse files Browse the repository at this point in the history
If the config script does not include any Request-URI altering logic
(e.g. no lookup() or $ru manipulation), the acc module would incorrectly fill
in a "msg->new_uri" field which should NOT be freed into the SIP request
structure, leading to the memory pool being corrupted upon transaction release.

Credits to Guillaume Lacroix for reporting

(cherry picked from commit 02cb9f0)
  • Loading branch information
liviuchircu committed Jul 4, 2016
1 parent e7f8d1b commit 63e25f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/acc/acc_logic.c
Expand Up @@ -481,7 +481,7 @@ static inline void on_missed(struct cell *t, struct sip_msg *req,
*/
reset_acc_flag( req, flags_to_reset );

if (new_uri_bk.s) {
if (t->nr_of_outgoings) {
req->new_uri = new_uri_bk;
req->dst_uri = dst_uri_bk;
req->parsed_uri_ok = 0;
Expand Down

0 comments on commit 63e25f5

Please sign in to comment.