Skip to content

Commit

Permalink
Fix missing "\n" log line endings
Browse files Browse the repository at this point in the history 
Credits to Nick Altmann for the hint!

(cherry picked from commit 8880b5f)
  • Loading branch information
@liviuchircu
liviuchircu committed Jan 12, 2021
1 parent 3c87de6 commit 7e1c189
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 38 deletions.
2 changes: 1 addition & 1 deletion modules/callops/callops.c
View file
Expand Up @@ -494,7 +494,7 @@ static int call_attended_transfer(struct dlg_cell *dlg, struct sip_msg *msg)
init_callid.len, init_callid.s);
}
} else {
LM_ERR("could not find the transfered callid");
LM_ERR("could not find the transfered callid\n");
}

call_dlg_api.store_dlg_value(rpl_dlg, &call_transfer_param, &rpl_leg);
Expand Down
2 changes: 1 addition & 1 deletion modules/cfgutils/cfgutils.c
View file
Expand Up @@ -408,7 +408,7 @@ mi_response_t *mi_check_hash(const mi_params_t *params,
return init_mi_error(404, MI_SSTR("Functionality disabled"));
} else {
if (MD5File(tmp, hash_file) != 0) {
LM_ERR("could not hash the config file");
LM_ERR("could not hash the config file\n");
return init_mi_error(500, MI_SSTR("Internal error"));
}

Expand Down
2 changes: 1 addition & 1 deletion modules/mmgeoip/mmgeoip.c
View file
Expand Up @@ -60,7 +60,7 @@ int parse_mem_option( unsigned int type, void *val)
#ifdef GEOIP
return legacy_parse_cache_type((char *)val);
#else
LM_INFO("Parameter only supported for legacy GeoIP, ignoring...");
LM_INFO("Parameter only supported for legacy GeoIP, ignoring...\n");
return 0;
#endif
}
Expand Down
2 changes: 1 addition & 1 deletion modules/presence_dfks/presence_dfks.c
View file
Expand Up @@ -966,7 +966,7 @@ void mi_feature_notify(int sender, void *_params)
notify_body = build_feature_notify(&params->pres_uri, params->feature_idx,
0, &params->param, &ct_type);
if (notify_body == (str*)-1) {
LM_ERR("Failed to build NOTIFY body");
LM_ERR("Failed to build NOTIFY body\n");
goto end;
}

Expand Down
60 changes: 30 additions & 30 deletions modules/proto_smpp/smpp.c
View file
Expand Up @@ -76,7 +76,7 @@ rw_lock_t *smpp_lock; /* reader-writers lock for reloading the data */
static uint32_t get_payload_from_header(char *payload, smpp_header_t *header)
{
if (!payload || !header) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
return 0;
}

Expand All @@ -92,7 +92,7 @@ static uint32_t get_payload_from_header(char *payload, smpp_header_t *header)
static uint32_t get_payload_from_bind_transceiver_body(char *body, smpp_bind_transceiver_t *transceiver)
{
if (!body || !transceiver) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
return 0;
}

Expand All @@ -111,7 +111,7 @@ static uint32_t get_payload_from_bind_transceiver_body(char *body, smpp_bind_tra
static uint32_t get_payload_from_bind_transceiver_resp_body(char *body, smpp_bind_transceiver_resp_t *transceiver_resp)
{
if (!body || !transceiver_resp) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
return 0;
}

Expand All @@ -124,7 +124,7 @@ static uint32_t get_payload_from_bind_transceiver_resp_body(char *body, smpp_bin
uint32_t get_payload_from_submit_sm_body(char *body, smpp_submit_sm_t *submit_sm)
{
if (!body || !submit_sm) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
return 0;
}

Expand Down Expand Up @@ -154,7 +154,7 @@ uint32_t get_payload_from_submit_sm_body(char *body, smpp_submit_sm_t *submit_sm
uint32_t get_payload_from_deliver_sm_resp_body(char *body, smpp_deliver_sm_resp_t *deliver_sm_resp)
{
if (!body || !deliver_sm_resp) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
return 0;
}

Expand All @@ -165,7 +165,7 @@ uint32_t get_payload_from_deliver_sm_resp_body(char *body, smpp_deliver_sm_resp_
uint32_t get_payload_from_submit_sm_resp_body(char *body, smpp_submit_sm_resp_t *submit_sm_resp)
{
if (!body || !submit_sm_resp) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
return 0;
}

Expand All @@ -176,33 +176,33 @@ uint32_t get_payload_from_submit_sm_resp_body(char *body, smpp_submit_sm_resp_t
static int build_bind_transceiver_request(smpp_bind_transceiver_req_t **preq, smpp_session_t *session)
{
if (!preq || !session) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
goto err;
}

/* request allocations */
smpp_bind_transceiver_req_t *req = pkg_malloc(sizeof(*req));
*preq = req;
if (!req) {
LM_ERR("malloc error for request");
LM_ERR("malloc error for request\n");
goto err;
}

smpp_header_t *header = pkg_malloc(sizeof(*header));
if (!header) {
LM_ERR("malloc error for header");
LM_ERR("malloc error for header\n");
goto header_err;
}

smpp_bind_transceiver_t *body = pkg_malloc(sizeof(*body));
if (!body) {
LM_ERR("malloc error for body");
LM_ERR("malloc error for body\n");
goto body_err;
}

req->payload.s = pkg_malloc(REQ_MAX_SZ(BIND_RECEIVER));
if (!req->payload.s) {
LM_ERR("malloc error for payload");
LM_ERR("malloc error for payload\n");
goto payload_err;
}

Expand Down Expand Up @@ -245,33 +245,33 @@ static int build_bind_resp_request(smpp_bind_transceiver_resp_req_t **preq, uint
uint32_t command_status, uint32_t seq_no, char *system_id)
{
if (!preq) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
goto err;
}

/* request allocations */
smpp_bind_transceiver_resp_req_t *req = pkg_malloc(sizeof(*req));
*preq = req;
if (!req) {
LM_ERR("malloc error for request");
LM_ERR("malloc error for request\n");
goto err;
}

smpp_header_t *header = pkg_malloc(sizeof(*header));
if (!header) {
LM_ERR("malloc error for header");
LM_ERR("malloc error for header\n");
goto header_err;
}

smpp_bind_transceiver_resp_t *body = pkg_malloc(sizeof(*body));
if (!body) {
LM_ERR("malloc error for body");
LM_ERR("malloc error for body\n");
goto body_err;
}

req->payload.s = pkg_malloc(REQ_MAX_SZ(BIND_TRANSCEIVER_RESP));
if (!req->payload.s) {
LM_ERR("malloc error for payload");
LM_ERR("malloc error for payload\n");
goto payload_err;
}

Expand Down Expand Up @@ -307,27 +307,27 @@ static int build_bind_resp_request(smpp_bind_transceiver_resp_req_t **preq, uint
static int build_enquire_link_request(smpp_enquire_link_req_t **preq, smpp_session_t *session)
{
if (!preq || !session) {
LM_ERR("NULL param");
LM_ERR("NULL param\n");
goto err;
}

/* request allocations */
smpp_enquire_link_req_t *req = pkg_malloc(sizeof(*req));
*preq = req;
if (!req) {
LM_ERR("malloc error for request");
LM_ERR("malloc error for request\n");
goto err;
}

smpp_header_t *header = pkg_malloc(sizeof(*header));
if (!header) {
LM_ERR("malloc error for header");
LM_ERR("malloc error for header\n");
goto header_err;
}

req->payload.s = pkg_malloc(REQ_MAX_SZ(ENQUIRE_LINK));
if (!req->payload.s) {
LM_ERR("malloc error for payload");
LM_ERR("malloc error for payload\n");
goto payload_err;
}

Expand Down Expand Up @@ -599,33 +599,33 @@ static int build_submit_or_deliver_request(smpp_submit_sm_req_t **preq,
char *start;

if (!preq || !src || !dst || !message) {
LM_ERR("NULL params");
LM_ERR("NULL params\n");
goto err;
}

/* request allocations */
smpp_submit_sm_req_t *req = pkg_malloc(sizeof(*req));
*preq = req;
if (!req) {
LM_ERR("malloc error for request");
LM_ERR("malloc error for request\n");
goto err;
}

smpp_header_t *header = pkg_malloc(sizeof(*header));
if (!header) {
LM_ERR("malloc error for header");
LM_ERR("malloc error for header\n");
goto header_err;
}

smpp_submit_sm_t *body = pkg_malloc(sizeof(*body));
if (!body) {
LM_ERR("malloc error for body");
LM_ERR("malloc error for body\n");
goto body_err;
}

req->payload.s = pkg_malloc(REQ_MAX_SZ(SUBMIT_SM));
if (!req->payload.s) {
LM_ERR("malloc error for payload");
LM_ERR("malloc error for payload\n");
goto payload_err;
}

Expand Down Expand Up @@ -703,33 +703,33 @@ static int build_submit_or_deliver_request(smpp_submit_sm_req_t **preq,
static int build_submit_or_deliver_resp_request(smpp_submit_sm_resp_req_t **preq, uint32_t command_id, uint32_t command_status, uint32_t sequence_number)
{
if (!preq) {
LM_ERR("NULL param");
LM_ERR("NULL param\n");
goto err;
}

/* request allocations */
smpp_submit_sm_resp_req_t *req = pkg_malloc(sizeof(*req));
*preq = req;
if (!req) {
LM_ERR("malloc error for request");
LM_ERR("malloc error for request\n");
goto err;
}

smpp_header_t *header = pkg_malloc(sizeof(*header));
if (!header) {
LM_ERR("malloc error for header");
LM_ERR("malloc error for header\n");
goto header_err;
}

smpp_submit_sm_resp_t *body = pkg_malloc(sizeof(*body));
if (!body) {
LM_ERR("malloc error for body");
LM_ERR("malloc error for body\n");
goto body_err;
}

req->payload.s = pkg_malloc(REQ_MAX_SZ(SUBMIT_SM_RESP));
if (!req->payload.s) {
LM_ERR("malloc error for payload");
LM_ERR("malloc error for payload\n");
goto payload_err;
}

Expand Down
2 changes: 1 addition & 1 deletion modules/qrouting/qr_stats.c
View file
Expand Up @@ -412,7 +412,7 @@ void qr_rld_prepare_part(void *param)
memset(pl, 0, sizeof *pl);

if (!(pl->rw_lock = lock_init_rw())) {
LM_ERR("failed to init rw lock");
LM_ERR("failed to init rw lock\n");
goto error;
}

Expand Down
6 changes: 3 additions & 3 deletions modules/stir_shaken/stir_shaken.c
View file
Expand Up @@ -535,7 +535,7 @@ static int build_unsigned_pport(str *buf, time_t iat_ts, str *attest,

hdr_json_str.s = build_pport_hdr_json(cr_url);
if (!hdr_json_str.s) {
LM_ERR("Failed to build PASSporT's json header");
LM_ERR("Failed to build PASSporT's json header\n");
return -1;
}
hdr_json_str.len = strlen(hdr_json_str.s);
Expand All @@ -545,7 +545,7 @@ static int build_unsigned_pport(str *buf, time_t iat_ts, str *attest,
payload_json_str.s = build_pport_payload_json(attest, orig_tn, dest_tn,
iat_ts, origid);
if (!payload_json_str.s) {
LM_ERR("Failed to build PASSporT's json payload");
LM_ERR("Failed to build PASSporT's json payload\n");
goto error;
}
payload_json_str.len = strlen(payload_json_str.s);
Expand Down Expand Up @@ -939,7 +939,7 @@ static int w_stir_auth(struct sip_msg *msg, str *attest, str *origid,
}

if (get_header_by_static_name(msg, "Identity")) {
LM_INFO("Identity header already exists");
LM_INFO("Identity header already exists\n");
return -2;
}

Expand Down

0 comments on commit 7e1c189

Please sign in to comment.