Fixed the EVI registered IDs & added some FIXMEs

Fixes #2928
OpenSIPS · Oct 18, 2022 · 806d356 · 806d356
1 parent c6bcd84
commit 806d356
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/evi/evi_core.c b/evi/evi_core.c
@@ -30,6 +30,8 @@
 /* static events exported by the core */
 static str evi_core_table[] = {
 	CORE_EVENT_STR(THRESHOLD),
+	/* FIXME - if no statistics, the EVI ids will not be working anymore,
+	 * since we don't save the actual ID registered in EVI */
 #ifdef STATISTICS
 	CORE_EVENT_STR(SHM_THRESHOLD),
 #endif

diff --git a/evi/evi_core.h b/evi/evi_core.h
@@ -27,11 +27,13 @@
 #define EVI_CORE_H
 
 /* events id declared - these must be always incremented by one */
-#define EVI_THRESHOLD_ID		0
-#define EVI_SHM_THRESHOLD_ID	1
-#define EVI_PKG_THRESHOLD_ID	2
-#define EVI_PROC_AUTO_SCALE_ID	3
-#define EVI_TCP_DISCONNECT	4
+/* FIXME - first EVI is E_CORE_SR_STATUS_CHANGED, done outside of EVI core here, 
+ * which is why we start indexing at 1 */ 
+#define EVI_THRESHOLD_ID	1
+#define EVI_SHM_THRESHOLD_ID	2
+#define EVI_PKG_THRESHOLD_ID	3
+#define EVI_PROC_AUTO_SCALE_ID	4
+#define EVI_TCP_DISCONNECT	5
 
 
 #define EVI_CORE_PREFIX		"E_CORE_"