Improve previous commit

* fix 2 regressions * optimize (merge) some HAVE() checks
OpenSIPS · Mar 28, 2022 · 85d7691 · 85d7691
1 parent 7312678
commit 85d7691
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/parser/case_call.h b/parser/case_call.h
@@ -31,8 +31,6 @@
 
 
 #define ID_INF_CASE                      \
-	if (!HAVE(4))                        \
-		goto other;                      \
 	switch(LOWER_DWORD(val)) {           \
 		case __id1_:                     \
 			hdr->type = HDR_CALLID_T;    \
@@ -59,6 +57,8 @@
 
 #define call_CASE      \
 	p += 4;            \
+	if (!HAVE(4))      \
+		goto other;    \
 	val = READ(p);     \
 	ID_INF_CASE;       \
 	goto other;

diff --git a/parser/case_cont.h b/parser/case_cont.h
@@ -67,8 +67,6 @@
 	switch(LOWER_DWORD(val)) {     \
 		case _osit_:               \
 		p += 4;                    \
-		if (!HAVE(4))              \
-			goto other;            \
 		val = READ(p);             \
 		ion_CASE;                  \
 		goto other;                \
@@ -91,7 +89,7 @@
 				goto dc_cont;               \
 		case _disp_:                        \
 				p += 4;                     \
-				if (!HAVE(4))               \
+				if (!HAVE(8))               \
 					goto other;             \
 				val = READ(p);              \
 				DISPOSITION_CASE;           \

diff --git a/parser/case_max.h b/parser/case_max.h
@@ -38,8 +38,6 @@
 	switch(LOWER_DWORD(val)) { \
 		case _forw_:           \
 			p += 4;            \
-			if (!HAVE(4))      \
-				goto other;    \
 			val = READ(p);     \
 			ARDS_CASE;         \
 		goto other;            \
@@ -48,7 +46,7 @@
 
 #define max_CASE      \
 	p += 4;           \
-	if (!HAVE(4))     \
+	if (!HAVE(8))     \
 		goto other;   \
 	val = READ(p);    \
 	FORW_CASE;        \

diff --git a/parser/case_reco.h b/parser/case_reco.h
@@ -38,8 +38,6 @@
 	switch(LOWER_DWORD(val)) { \
 		case _rd_r_:           \
 			p += 4;            \
-			if (!HAVE(4))      \
-				goto other;    \
 			val = READ(p);     \
 			OUTE_CASE;         \
 			goto other;        \
@@ -48,7 +46,7 @@
 
 #define reco_CASE     \
 	p += 4;           \
-	if (!HAVE(4))     \
+	if (!HAVE(8))     \
 		goto other;   \
 	val = READ(p);    \
 	RD_R_CASE;        \

diff --git a/parser/parse_hname2.c b/parser/parse_hname2.c
@@ -109,7 +109,7 @@ static inline char* skip_ws(char* p, char *end)
 
 #ifdef FUZZ_BUILD
 /* fuzzers are sensible to heap read overflows, so enable all "HAVE" checks */
-#define HAVE(bytes) (end - p < (bytes))
+#define HAVE(bytes) (end - p >= (long)(bytes))
 #else
 /* with PKG memory, parser read overflows of a few bytes are harmless, since
  * the memory is pre-allocated and the read cannot SIGSEGV, making the parser