Skip to content

Commit

Permalink
Use LM_ERR() not LM_CRIT() to report parsing errors, like we do
Browse files Browse the repository at this point in the history
in other cases.
  • Loading branch information
sobomax committed Mar 14, 2023
1 parent 7f84599 commit 91990d6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion parser/parse_uri.c
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,7 @@ int parse_uri(char* buf, int len, struct sip_uri* uri)
len, ZSW(buf), len);
goto error_exit;
error_bug:
LM_CRIT("bad state %d parsed: <%.*s> (%d) / <%.*s> (%d)\n",
LM_ERR("bad state %d parsed: <%.*s> (%d) / <%.*s> (%d)\n",
state, (int)(p-buf), ZSW(buf), (int)(p-buf), len, ZSW(buf), len);
error_exit:
ser_error=E_BAD_URI;
Expand Down
16 changes: 8 additions & 8 deletions parser/parse_via.c
Original file line number Diff line number Diff line change
Expand Up @@ -1712,7 +1712,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
state=saved_state;
break;
default:
LM_CRIT("on <%c>, state=%d\n",*tmp, state);
LM_ERR("on <%c>, state=%d\n",*tmp, state);
goto parse_error;
}
break;
Expand Down Expand Up @@ -1800,7 +1800,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
state=saved_state;
goto endofheader;
default:
LM_CRIT("on <%c>\n",*tmp);
LM_ERR("on <%c>\n",*tmp);
goto parse_error;
}
break;
Expand Down Expand Up @@ -1845,7 +1845,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
case P_COMMENT: /*everything is allowed in a comment*/
break;
default:
LM_CRIT("on <%c> state %d\n", *tmp, state);
LM_ERR("on <%c> state %d\n", *tmp, state);
goto parse_error;
}
break;
Expand Down Expand Up @@ -1901,7 +1901,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
break;

default:
LM_CRIT("on <%c> state %d\n", *tmp, state);
LM_ERR("on <%c> state %d\n", *tmp, state);
goto parse_error;
}
break;
Expand Down Expand Up @@ -1949,7 +1949,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
case P_COMMENT: /*everything is allowed in a comment*/
break;
default:
LM_CRIT("on <%c> state %d\n",*tmp, state);
LM_ERR("on <%c> state %d\n",*tmp, state);
goto parse_error;
}
break;
Expand Down Expand Up @@ -1998,7 +1998,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
/*previous=crlf and now !=' '*/
goto endofheader;
default:
LM_CRIT("on <%c> state %d\n", *tmp, state);
LM_ERR("on <%c> state %d\n", *tmp, state);
goto parse_error;
}
break;
Expand Down Expand Up @@ -2038,7 +2038,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
/*previous=crlf and now !=' '*/
goto endofheader;
default:
LM_CRIT("on <%c> state %d\n", *tmp, state);
LM_ERR("on <%c> state %d\n", *tmp, state);
goto parse_error;
}
break;
Expand Down Expand Up @@ -2211,7 +2211,7 @@ char* parse_via(char* buffer, char* end, struct via_body *vbody)
/*previous=crlf and now !=' '*/
goto endofheader;
default:
LM_CRIT("invalid char <%c> in state %d\n",*tmp, state);
LM_ERR("invalid char <%c> in state %d\n",*tmp, state);
goto parse_error;
}

Expand Down

0 comments on commit 91990d6

Please sign in to comment.