Skip to content

Commit

Permalink
script_helper: minor logging improvements
Browse files Browse the repository at this point in the history
Do not report errors when ACKs to 487 responses fail to match any on-going dialogues
Reported by Gary Nyquist
(cherry picked from commit a1b0495)
  • Loading branch information
liviuchircu committed Jul 1, 2014
1 parent e15757f commit a8d8d3c
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions modules/script_helper/script_helper.c
Expand Up @@ -128,7 +128,9 @@ int run_helper_logic(struct sip_msg *msg, void *param)
str status_500 = str_init("Server Internal Error");
int rc, seq_request = 0;

LM_DBG("running helper logic\n");
LM_DBG("running script helper for <%.*s>\n",
msg->first_line.u.request.method.len,
msg->first_line.u.request.method.s);

if (parse_headers(msg, HDR_TO_F|HDR_CALLID_F, 0) == -1) {
LM_ERR("failed to parse To header\n");
Expand All @@ -149,7 +151,9 @@ int run_helper_logic(struct sip_msg *msg, void *param)

/* attempt a full dialog search (not the usual quick did lookup) */
if (use_dialog && dlg_api.match_dialog(msg) < 0)
LM_ERR("failed to match dialog, ci '%.*s'\n",
LM_DBG("failed to match dialog for <%.*s>, ci '%.*s'\n",
msg->first_line.u.request.method.len,
msg->first_line.u.request.method.s,
msg->callid->body.len, msg->callid->body.s);

if (msg->REQ_METHOD == METHOD_ACK) {
Expand Down

0 comments on commit a8d8d3c

Please sign in to comment.